Skip to content

sync(common-v8): cautious wave2 runtime sync (no-eslint)#60

Merged
miccy merged 4 commits intosync/common-v8-2026-03-01-wave1from
sync/common-v8-2026-03-01-wave2-runtime
Mar 1, 2026
Merged

sync(common-v8): cautious wave2 runtime sync (no-eslint)#60
miccy merged 4 commits intosync/common-v8-2026-03-01-wave1from
sync/common-v8-2026-03-01-wave2-runtime

Conversation

@miccy
Copy link
Copy Markdown
Contributor

@miccy miccy commented Mar 1, 2026

Summary

Wave2 is a cautious runtime-focused sync from upstream/common-v8 on top of Wave1.

Scope is intentionally small and excludes ESLint v10.

PORTED

  • 904c47e Add arrayFromAsync and tests
  • 012108c React Native: isolate worker runs and add tests (selective, fork-compatible)
  • 58b0fe3 Remove stray console.log of Symbol.asyncDispose (no-op in this fork, tracked explicitly)

DEFERRED

  • 87f87d5 Add array/promise polyfills and remove runtime checks (Wave2b)
  • 0d6d853 Create .gitignore (non-blocking, defer with example cleanup)

SKIPPED

  • 3c0f25c ESLint v10 upgrade (explicitly out of scope)

Risks and Mitigations

  • RN worker/local-auth flow impact from 012108c
    • Mitigation: targeted RN shared test + full test run + expo web export
  • Additive API export mismatch for arrayFromAsync
    • Mitigation: build + targeted array tests + full test run
  • Lockfile drift
    • Mitigation: no extra dependency bumps added in this wave

Test Results

  • bun run build
  • bun run test
  • bun run lint ✅ (4 existing warnings in packages/react-native/test/Polyfills.test.ts, no errors)
  • bun run coverage:lane:active
  • (cd examples/react-expo && bun run web:export)
  • bunx vitest run --project react-native packages/react-native/test/shared.test.ts
  • bunx vitest run packages/common/test/Array.test.ts

Notes

  • PR is stacked on top of Wave1 (#58) and targets sync/common-v8-2026-03-01-wave1 as base.
  • After Wave1 merge, this PR can be retargeted to main.

miccy added 4 commits March 1, 2026 21:37
Source upstream commit: 904c47ea8fc7a464f906dd92435950740fa83ec3

Port scope: full.
Source upstream commit: 012108ce6d886f8a0c6873d6d0f01a6e5d864eb6

Port scope: selective (runtime + tests). Kept example app unchanged due fork divergence; aligned test path casing to shared.test.ts.
Source upstream commit: 58b0fe34f612c7630a6b4953f6df4b2160e93da2

Port scope: no-op in fork (log statement not present after prior divergence).
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 1, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch sync/common-v8-2026-03-01-wave2-runtime

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@miccy miccy marked this pull request as ready for review March 1, 2026 20:52
@miccy miccy requested a review from a team as a code owner March 1, 2026 20:52
@miccy miccy merged commit 0ad065c into sync/common-v8-2026-03-01-wave1 Mar 1, 2026
30 of 31 checks passed
@miccy miccy deleted the sync/common-v8-2026-03-01-wave2-runtime branch March 1, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant