sync(common-v8): cautious wave2 runtime sync (no-eslint)#60
Merged
miccy merged 4 commits intosync/common-v8-2026-03-01-wave1from Mar 1, 2026
Merged
Conversation
Source upstream commit: 904c47ea8fc7a464f906dd92435950740fa83ec3 Port scope: full.
Source upstream commit: 012108ce6d886f8a0c6873d6d0f01a6e5d864eb6 Port scope: selective (runtime + tests). Kept example app unchanged due fork divergence; aligned test path casing to shared.test.ts.
Source upstream commit: 58b0fe34f612c7630a6b4953f6df4b2160e93da2 Port scope: no-op in fork (log statement not present after prior divergence).
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wave2 is a cautious runtime-focused sync from
upstream/common-v8on top of Wave1.Scope is intentionally small and excludes ESLint v10.
PORTED
904c47eAddarrayFromAsyncand tests012108cReact Native: isolate worker runs and add tests (selective, fork-compatible)58b0fe3Remove strayconsole.logofSymbol.asyncDispose(no-op in this fork, tracked explicitly)DEFERRED
87f87d5Add array/promise polyfills and remove runtime checks (Wave2b)0d6d853Create.gitignore(non-blocking, defer with example cleanup)SKIPPED
3c0f25cESLint v10 upgrade (explicitly out of scope)Risks and Mitigations
012108carrayFromAsyncTest Results
bun run build✅bun run test✅bun run lint✅ (4 existing warnings inpackages/react-native/test/Polyfills.test.ts, no errors)bun run coverage:lane:active✅(cd examples/react-expo && bun run web:export)✅bunx vitest run --project react-native packages/react-native/test/shared.test.ts✅bunx vitest run packages/common/test/Array.test.ts✅Notes
#58) and targetssync/common-v8-2026-03-01-wave1as base.main.