-
Notifications
You must be signed in to change notification settings - Fork 3
1008 replace smooth seeking with scrubbingmode #1212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
StaehliJ
wants to merge
5
commits into
main
Choose a base branch
from
1008-replace-smoothSeeking-with-scrubbingmode
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently doesn't work with image track.
5 tasks
Code Coverage
Files
|
waliid
reviewed
Dec 1, 2025
pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/session/PillarboxMediaController.kt
Outdated
Show resolved
Hide resolved
...-demo-shared/src/main/java/ch/srgssr/pillarbox/demo/shared/ui/player/ProgressTrackerState.kt
Outdated
Show resolved
Hide resolved
pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/session/PillarboxMediaController.kt
Show resolved
Hide resolved
pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/PillarboxLoadControl.kt
Outdated
Show resolved
Hide resolved
…arboxLoadControl.kt Co-authored-by: Walid Kayhal <[email protected]>
waliid
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Media3 introduce
scrubbingModeto ExoPlayer that does exactly what Pillarbox smooth seeking is doing. The goal of this PR is to replace it with the media3 way.Changes made
SimpleProgressTrackerthat handle also scrubbingModeSmoothingSeekingProgressTrackerStateis now dedicated to thumbnail seeking from player image track.Checklist