Skip to content

Conversation

@StaehliJ
Copy link
Contributor

Description

Media3 introduce scrubbingMode to ExoPlayer that does exactly what Pillarbox smooth seeking is doing. The goal of this PR is to replace it with the media3 way.

Changes made

  • Change SimpleProgressTracker that handle also scrubbingMode
  • Old SmoothingSeekingProgressTrackerState is now dedicated to thumbnail seeking from player image track.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@StaehliJ StaehliJ linked an issue Nov 18, 2025 that may be closed by this pull request
5 tasks
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Pillarbox Nov 18, 2025
@github-actions
Copy link

github-actions bot commented Nov 18, 2025

Code Coverage

Overall Project 48.07% -0.67% 🟢
Files changed 13.47% 🟢

Module Coverage
:pillarbox-player 57.49% -0.56% 🟢
:pillarbox-cast 29.19% -0.05% 🟢
:pillarbox-cast-receiver 20.01% 🟢
:pillarbox-ui 3.62% -3.06% 🟢
Files
Module File Coverage
:pillarbox-player PillarboxExoPlayer.kt 88.57% 🟢
PillarboxAnalyticsCollector.kt 87.13% 🟢
PillarboxBuilder.kt 79.17% 🟢
PillarboxLoadControl.kt 78.26% 🟢
PillarboxPlayer.kt 5.36% 🟢
PillarboxAnalyticsListener.kt 0% 🟢
PillarboxSessionCommands.kt 0% -9.32% 🟢
PillarboxMediaController.kt 0% -1.83% 🟢
PillarboxMediaSession.kt 0% 🟢
MediaSessionCallbackImpl.kt 0% -9.81% 🟢
:pillarbox-cast PillarboxCastPlayer.kt 1.07% -0.1% 🟢
:pillarbox-cast-receiver PillarboxCastReceiverPlayer.kt 0% 🟢
:pillarbox-ui ImageProgressTrackerState.kt 0% -57.34% 🟢
SimpleProgressTrackerState.kt 0% -57.35% 🟢

@JordanMontel JordanMontel removed the status in Pillarbox Nov 24, 2025
@StaehliJ StaehliJ requested review from defagos and waliid November 28, 2025 10:51
@StaehliJ StaehliJ moved this to 🍿 Code Review in Pillarbox Nov 28, 2025
@StaehliJ StaehliJ enabled auto-merge December 2, 2025 10:16
@StaehliJ StaehliJ requested a review from waliid December 2, 2025 13:35
@StaehliJ StaehliJ added this pull request to the merge queue Dec 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 2, 2025
@StaehliJ StaehliJ added this pull request to the merge queue Dec 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🍿 Code Review

Development

Successfully merging this pull request may close these issues.

Investigate setScrubbingModeEnabled to remove setSmoothSeeking

2 participants