173169085-oneway-trip :create oneway trip #12
Conversation
brianineza01
force-pushed
the
ft-create-oneway-trip-173169085
branch
3 times, most recently
from
703202a to
17eef63
Compare
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| getAllTrips: () => dispatch(getTrips()) | ||
| }); | ||
|
|
||
| export default connect(mapStateToProps, mapDispatchToProps)(LatestTrips); |
There was a problem hiding this comment.
Replace mapStateToProps,·mapDispatchToProps with ⏎··mapStateToProps,⏎··mapDispatchToProps⏎ prettier/prettier
brianineza01
force-pushed
the
ft-create-oneway-trip-173169085
branch
2 times, most recently
from
556b640 to
c05b7de
Compare
| createOneWayTripAction: form => dispatch(createOneWayTrip(form)) | ||
| }); | ||
|
|
||
| export default connect(mapStateToProps, mapDispatchToProps)(OneWayTripForm); |
There was a problem hiding this comment.
Replace mapStateToProps,·mapDispatchToProps with ⏎··mapStateToProps,⏎··mapDispatchToProps⏎ prettier/prettier
brianineza01
force-pushed
the
ft-create-oneway-trip-173169085
branch
5 times, most recently
from
2a46f68 to
37fdb88
Compare
brianineza01
added
PEER REVIEW
brianineza01
force-pushed
the
ft-create-oneway-trip-173169085
branch
from
37fdb88 to
9f192c5
Compare
brianineza01
force-pushed
the
ft-create-oneway-trip-173169085
branch
from
9f192c5 to
fb8ac3e
Compare
brianineza01
force-pushed
the
ft-create-oneway-trip-173169085
branch
2 times, most recently
from
5687f9f to
59ca596
Compare
brianineza01
force-pushed
the
ft-create-oneway-trip-173169085
branch
from
59ca596 to
865d273
Compare
| this.state = initialState; | ||
| } | ||
|
|
||
| componentDidUpdate(prevProps) { |
| departureDate: today | ||
| }; | ||
|
|
||
| /** |
| color: $trip-status-text-color; | ||
| display: block; | ||
| font-family: $font-family; | ||
| font-style: normal; |
There was a problem hiding this comment.
Properties should be ordered color, display, font-family, font-size, font-style, font-weight, line-height, margin-top
| .trip-status { | ||
| background-color: $block-background-color; | ||
| border-radius: 20px; | ||
| box-shadow: 0px 10px 15px $block-box-shadow-color; |
There was a problem hiding this comment.
0px should be written without units as 0
brianineza01
force-pushed
the
ft-create-oneway-trip-173169085
branch
from
865d273 to
983a92a
Compare
| import "./Sidebar.scss"; | ||
|
|
||
| const Sidebar = ({ onChange, selectedItem }) => { | ||
| const onItemClicked = item => { |
There was a problem hiding this comment.
Unexpected block statement surrounding arrow body; move the returned value immediately after the => arrow-body-style
| import { string, bool } from "prop-types"; | ||
| import "./Sidebar.scss"; | ||
|
|
||
| function SidebarItem(props) { |
| import React from "react"; | ||
| import "./Content.scss"; | ||
|
|
||
| function ContentComponent() { |
| import Content from "./Content/Content.jsx"; | ||
| import "./Dashboard.scss"; | ||
|
|
||
| const Dashboard = () => { |
There was a problem hiding this comment.
Unexpected block statement surrounding arrow body; move the returned value immediately after the => arrow-body-style
| } | ||
|
|
||
| &:hover { | ||
| background-color: #687cd7; |
There was a problem hiding this comment.
Color literals like #687cd7 should only be used in variable declarations; they should be referred to via variable everywhere else.
| } | ||
| } | ||
|
|
||
| .toggle-menu-button { |
There was a problem hiding this comment.
Rule set contains (14/10) properties
| font-weight: 900; | ||
| font-size: 16px; | ||
| line-height: 19px; | ||
| color: #ffffff; |
There was a problem hiding this comment.
Color literals like #ffffff should only be used in variable declarations; they should be referred to via variable everywhere else.
|
|
||
| &__menu-item-title, | ||
| .expanded-menu { | ||
| margin-left: 24px; |
There was a problem hiding this comment.
Properties should be ordered color, font-size, font-style, font-weight, line-height, margin-left
| height: 45px; | ||
| color: #fff; | ||
| margin-top: auto; | ||
| padding: 15px 0 0 22px; |
There was a problem hiding this comment.
Shorthands of length 4 are not allowed. Value was 15px 0 0 22px
| border-top: 1px solid #ffffff47; | ||
| font-size: 14px; | ||
| height: 45px; | ||
| color: #fff; |
There was a problem hiding this comment.
Color literals like #fff should only be used in variable declarations; they should be referred to via variable everywhere else.
brianineza01
force-pushed
the
ft-create-oneway-trip-173169085
branch
from
983a92a to
d70c3fd
Compare
| * for LatestTrips component | ||
| */ | ||
| export class LatestTrips extends Component { | ||
| constructor(props) { |
|
|
||
| import "./LatestTrips.scss"; | ||
|
|
||
| /** |
There was a problem hiding this comment.
Missing JSDoc @returns for function valid-jsdoc
Missing JSDoc for parameter 'newTrips' valid-jsdoc
Missing JSDoc for parameter 'pageNumber' valid-jsdoc
| height: unset; | ||
| margin-left: 5px; | ||
| padding-top: 15px; | ||
| &__title { |
There was a problem hiding this comment.
Rule declaration should be preceded by an empty line
| } | ||
|
|
||
| &__date { | ||
| color: rgba(0, 1, 0, 0.5); |
There was a problem hiding this comment.
Color literals like rgba(0, 1, 0, 0.5) should only be used in variable declarations; they should be referred to via variable everywhere else.
| margin-left: 20px; | ||
|
|
||
| &__title { | ||
| color: rgba(0, 1, 0, 0.8); |
There was a problem hiding this comment.
Color literals like rgba(0, 1, 0, 0.8) should only be used in variable declarations; they should be referred to via variable everywhere else.
|
|
||
| .Place-container { | ||
| background: #f7f7f7; | ||
| display: flex; |
There was a problem hiding this comment.
Properties should be ordered background, border-radius, box-sizing, display, height, margin, padding, position, width
| $font-family: "Roboto", sans-serif; | ||
|
|
||
| .Place-container { | ||
| background: #f7f7f7; |
There was a problem hiding this comment.
Color literals like #f7f7f7 should only be used in variable declarations; they should be referred to via variable everywhere else.
| @@ -0,0 +1,47 @@ | |||
| $font-family: "Roboto", sans-serif; | |||
|
|
|||
| .Place-container { | |||
There was a problem hiding this comment.
Selector Place-container should be written in lowercase with hyphens
| .place-badge { | ||
| margin-bottom: 5px; | ||
| width: 120px; | ||
| &--oval { |
There was a problem hiding this comment.
Rule declaration should be preceded by an empty line
| .place-badge { | ||
| margin-right: 2px; | ||
| width: 120px; | ||
| &--oval { |
There was a problem hiding this comment.
Rule declaration should be preceded by an empty line
- Create the popup modal for inserting data - create the action creators for trip and Places - Link the created elements with their corresponding Components - test all functionality [Finishes #173169085]
brianineza01
force-pushed
the
ft-create-oneway-trip-173169085
branch
from
d70c3fd to
bde535e
Compare
| margin-right: 12px; | ||
| } | ||
| } | ||
| @media (max-width: 480px) { |
| margin-left: 12px; | ||
| margin-right: 12px; | ||
| } | ||
| } |
| } | ||
| .icon-styles { | ||
| margin-left: 12px; | ||
| } |
There was a problem hiding this comment.
Rule declaration should be followed by an empty line
| } | ||
| .title { | ||
| margin-left: 36px; | ||
| } |
There was a problem hiding this comment.
Rule declaration should be followed by an empty line
| @media (max-width: 768px) { | ||
| .name { | ||
| display: "none"; | ||
| } |
There was a problem hiding this comment.
Rule declaration should be followed by an empty line
| } | ||
|
|
||
| .separator { | ||
| border-left: "1px solid #DFE0EB"; |
There was a problem hiding this comment.
Color #DFE0EB should be written as #dfe0eb
| line-height: 21px; | ||
| text-align: right; | ||
|
|
||
| color: rgba(0, 0, 0, 0.5); |
There was a problem hiding this comment.
Color literals like rgba(0, 0, 0, 0.5) should only be used in variable declarations; they should be referred to via variable everywhere else.
| } | ||
|
|
||
| .name { | ||
| font-family: Roboto; |
There was a problem hiding this comment.
Properties should be ordered color, font-family, font-size, font-style, font-weight, line-height, text-align
| border-radius: 50px; | ||
| margin-left: 14px; | ||
| margin-right: 14px; | ||
| border: "1px solid #DFE0EB"; |
There was a problem hiding this comment.
Color #DFE0EB should be written as #dfe0eb
| } | ||
|
|
||
| .avatar { | ||
| height: 35px; |
There was a problem hiding this comment.
Properties should be ordered border, border-radius, height, margin-left, margin-right, width
Description
This PR adds create oneWay trip functionality from the UI to the codebase
Type of change
Please select the relevant option
How Has This Been Tested?
How to test?
Screnshoot?
STORY ID
[Finishes #173169085]