171648125 Add approval table UI #15

Agnes-N · 2020-06-23T18:54:07Z

Description

This PR is for creating approval table UI.

Type of change

Please select the relevant option

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Others (cosmetics, styling, improvements)
This change requires a documentation update

How Has This Been Tested?

Unit
Integration
End-to-end
No testing required

How to test?

N/A

Screnshoot?

N/A

STORY ID

[Finishes #171648125]

hound · 2020-06-24T22:42:59Z

src/Redux/Actions/ApprovalTable/approvalTableAction.js

+  };
+};
+
+export const approvalFailed = payload => {


Unexpected block statement surrounding arrow body; parenthesize the returned value and move it immediately after the => arrow-body-style

hound · 2020-06-24T22:43:00Z

src/Redux/Actions/ApprovalTable/approvalTableAction.js

+  };
+};
+
+export const approvalSuccess = payload => {


Unexpected block statement surrounding arrow body; parenthesize the returned value and move it immediately after the => arrow-body-style

hound · 2020-06-24T22:43:00Z

src/Redux/Actions/ApprovalTable/approvalTableAction.js

+
+const basePath = "https://champs-bn-api.herokuapp.com/api/v1";
+
+export const approvalRequest = () => {


Unexpected block statement surrounding arrow body; parenthesize the returned value and move it immediately after the => arrow-body-style

hound · 2020-06-24T22:43:00Z

src/Components/Shared/Dashboard/Sidebar/SidebarItem.jsx

+import { string, bool } from "prop-types";
+import "./Sidebar.scss";
+
+function SidebarItem(props) {


Missing JSDoc comment require-jsdoc

hound · 2020-06-24T22:43:00Z

src/Components/Shared/Dashboard/Sidebar/Sidebar.jsx

+import "./Sidebar.scss";
+
+const Sidebar = ({ onChange, selectedItem }) => {
+  const onItemClicked = item => {


Unexpected block statement surrounding arrow body; move the returned value immediately after the => arrow-body-style

hound · 2020-06-24T22:43:01Z

src/Components/Shared/Dashboard/Sidebar/Sidebar.scss

+      background-image: url(../../../../Assets/DashboardAssets/right.png);
+
+      &:hover {
+        background-color: #687cd7;


Color literals like #687cd7 should only be used in variable declarations; they should be referred to via variable everywhere else.

hound · 2020-06-24T22:43:02Z

src/Components/Shared/Dashboard/Sidebar/Sidebar.scss

+
+    @media (max-width: 1024px) {
+      background-image: url(../../../../Assets/DashboardAssets/right.png);
+


Line contains trailing whitespace

hound · 2020-06-24T22:43:02Z

src/Components/Shared/Dashboard/Sidebar/Sidebar.scss

+    box-shadow: 0 0 2px 1px #fff;
+
+    @media (max-width: 1024px) {
+      background-image: url(../../../../Assets/DashboardAssets/right.png);


URLs should be enclosed in quotes

hound · 2020-06-24T22:43:02Z

src/Components/Shared/Dashboard/Sidebar/Sidebar.scss

+    z-index: 1000;
+    border-radius: 50%;
+    box-shadow: 0 0 2px 1px #fff;
+


Line contains trailing whitespace

hound · 2020-06-24T22:43:02Z

src/Components/Shared/Dashboard/Sidebar/Sidebar.scss

+    background-size: cover;
+    z-index: 1000;
+    border-radius: 50%;
+    box-shadow: 0 0 2px 1px #fff;


Color literals like #fff should only be used in variable declarations; they should be referred to via variable everywhere else.

hound · 2020-06-24T22:45:47Z

src/Components/Shared/Dashboard/Sidebar/Sidebar.scss

+    width: 20px;
+    height: 20px;
+    background-image: url(../../../../Assets/DashboardAssets/left.png);
+    background-color: #f7f7f7;


Color literals like #f7f7f7 should only be used in variable declarations; they should be referred to via variable everywhere else.

hound · 2020-06-24T22:45:47Z

src/Components/Shared/Dashboard/Sidebar/Sidebar.scss

+    font-size: 20px;
+    width: 20px;
+    height: 20px;
+    background-image: url(../../../../Assets/DashboardAssets/left.png);


URLs should be enclosed in quotes

hound · 2020-06-24T22:45:47Z

src/Components/Shared/Dashboard/Sidebar/Sidebar.scss

+  }
+
+  .toggle-menu-button {
+    position: absolute;


Properties should be ordered background-color, background-image, background-position, background-repeat, background-size, border-radius, bottom, box-shadow, font-size, height, position, right, width, z-index

hound · 2020-06-24T22:45:47Z

src/Components/Shared/Dashboard/Sidebar/Sidebar.scss

+    }
+  }
+
+  .toggle-menu-button {


Line should be indented 0 spaces, but was indented 2 spaces
Rule set contains (14/10) properties

hound · 2020-06-24T22:45:47Z

src/Components/Shared/Dashboard/Sidebar/Sidebar.scss

+      }
+    }
+  }
+


Line contains trailing whitespace

hound · 2020-06-24T22:45:48Z

src/Components/Shared/Dashboard/Sidebar/Sidebar.scss

+      border-top: 1px solid #ffffff47;
+      font-size: 14px;
+      height: 45px;
+      color: #fff;


Color literals like #fff should only be used in variable declarations; they should be referred to via variable everywhere else.

hound · 2020-06-24T22:45:49Z

src/Components/Shared/Dashboard/Sidebar/Sidebar.scss

+
+    &__menu-setting {
+      border-top: 1px solid #ffffff47;
+      font-size: 14px;


Properties should be ordered border-top, color, font-size, height, margin-top, padding

hound · 2020-06-24T22:45:49Z

src/Components/Shared/Dashboard/Sidebar/Sidebar.scss

+      height: 22px;
+    }
+
+    &__menu-setting {


Line should be indented 2 spaces, but was indented 4 spaces

hound · 2020-06-24T22:45:49Z

src/Components/Shared/Dashboard/Sidebar/Sidebar.scss

+      width: 22px;
+      height: 22px;
+    }
+


Line contains trailing whitespace

hound · 2020-06-24T22:45:49Z

src/Components/Shared/Dashboard/Sidebar/Sidebar.scss

+    }
+
+    &__icon {
+      width: 22px;


Properties should be ordered height, width

hound · 2020-06-25T09:39:56Z

src/Components/Shared/Dashboard/Content/Content.scss

@@ -0,0 +1,3 @@
+.content {
+    font-family: "Roboto";


Line should be indented 2 spaces, but was indented 4 spaces

hound · 2020-06-25T09:39:56Z

src/Components/Shared/Dashboard/Sidebar/Sidebar.scss

+      }
+    }
+
+    &__icon {


Line should be indented 2 spaces, but was indented 4 spaces

hound · 2020-06-25T09:39:56Z

src/Components/Shared/Dashboard/Sidebar/Sidebar.scss

+        cursor: pointer;
+      }
+    }
+


Line contains trailing whitespace

hound · 2020-06-25T09:39:57Z

src/Components/Shared/Dashboard/Sidebar/Sidebar.scss

+      &:hover,
+      &__selected {
+        background: rgba(255, 255, 255, 0.05);
+        box-shadow: inset -7px 0 0 0 #f5f5f5;


Color literals like #f5f5f5 should only be used in variable declarations; they should be referred to via variable everywhere else.

hound · 2020-06-25T09:39:57Z

src/Components/Shared/Dashboard/Sidebar/Sidebar.scss

+      text-decoration: none;
+      &:hover,
+      &__selected {
+        background: rgba(255, 255, 255, 0.05);


Color literals like rgba(255, 255, 255, 0.05) should only be used in variable declarations; they should be referred to via variable everywhere else.

hound · 2020-06-25T09:39:58Z

src/Components/Shared/Dashboard/Sidebar/Sidebar.scss

+        #d17af0 0%,
+        #2a96cc 100%
+      );
+


Line contains trailing whitespace

hound · 2020-06-25T09:39:58Z

src/Components/Shared/Dashboard/Sidebar/Sidebar.scss

+      background: radial-gradient(
+        1355.92% 61.47% at 49.49% 50.08%,
+        #d17af0 0%,
+        #2a96cc 100%


Color literals like #2a96cc should only be used in variable declarations; they should be referred to via variable everywhere else.

hound · 2020-06-25T09:39:58Z

src/Components/Shared/Dashboard/Sidebar/Sidebar.scss

+      width: 170px;
+      background: radial-gradient(
+        1355.92% 61.47% at 49.49% 50.08%,
+        #d17af0 0%,


Color literals like #d17af0 should only be used in variable declarations; they should be referred to via variable everywhere else.

hound · 2020-06-25T09:39:58Z

src/Components/Shared/Dashboard/Sidebar/Sidebar.scss

+    }
+
+    &__menu {
+      display: flex;


Properties should be ordered background, display, flex-direction, height, list-style, margin, padding-left, width

hound · 2020-06-25T09:39:58Z

src/Components/Shared/Dashboard/Sidebar/Sidebar.scss

+      display: none;
+    }
+
+    &__menu {


Line should be indented 2 spaces, but was indented 4 spaces

- add approval table UI. [Finishes#171648125]

hound · 2020-06-29T23:45:19Z

src/Components/ViewTrips/ViewTrips.jsx

+import React from "react";
+import LatestTripsContainer from "../LatestTrips/LatestTrips.jsx";
+
+const ViewTrips = () => {


Unexpected block statement surrounding arrow body; move the returned value immediately after the => arrow-body-style

hound · 2020-06-29T23:45:19Z

src/Components/LatestTrips/LatestTrips.jsx

+  getAllTrips: () => dispatch(getTrips())
+});
+
+export default connect(mapStateToProps, mapDispatchToProps)(LatestTrips);


Replace mapStateToProps,·mapDispatchToProps with ⏎··mapStateToProps,⏎··mapDispatchToProps⏎ prettier/prettier

hound · 2020-06-29T23:45:19Z

src/Components/Shared/Dashboard/Dashboard.scss

+    .grid-container {
+      grid-template-columns: 1fr;
+      grid-template-rows: 72px 1fr;
+      grid-template-areas:


Colon after property should be followed by one space

hound · 2020-06-29T23:45:20Z

src/Components/Shared/Dashboard/Dashboard.scss

+  @media screen and (max-width: 480px) {
+    .grid-container {
+      grid-template-columns: 1fr;
+      grid-template-rows: 72px 1fr;


Unknown property grid-template-rows
fr units not allowed on grid-template-rows; must be one of (%, Hz, ch, cm, deg, dpcm, dpi, dppx, em, ex, grad, in, kHz, mm, ms, pc, pt, px, q, rad, rem, s, turn, vh, vmax, vmin, vw)

hound · 2020-06-29T23:45:20Z

src/Components/Shared/Dashboard/Dashboard.scss

+
+  @media screen and (max-width: 480px) {
+    .grid-container {
+      grid-template-columns: 1fr;


Properties should be ordered grid-template-areas, grid-template-columns, grid-template-rows
Unknown property grid-template-columns
fr units not allowed on grid-template-columns; must be one of (%, Hz, ch, cm, deg, dpcm, dpi, dppx, em, ex, grad, in, kHz, mm, ms, pc, pt, px, q, rad, rem, s, turn, vh, vmax, vmin, vw)

hound · 2020-06-29T23:45:21Z

src/Components/Shared/Dashboard/Dashboard.scss

+
+  .grid-container {
+    display: grid;
+    grid-template-columns: 170px auto;


Properties should be ordered display, grid-template-areas, grid-template-columns, grid-template-rows, height
Unknown property grid-template-columns

hound · 2020-06-29T23:45:21Z

src/Components/Shared/Dashboard/Dashboard.scss

+    padding: 15px;
+  }
+
+  .grid-container {


Line should be indented 0 spaces, but was indented 2 spaces

hound · 2020-06-29T23:45:21Z

src/Components/Shared/Dashboard/Dashboard.scss

+    grid-area: main;
+    padding: 15px;
+  }
+


Line contains trailing whitespace

hound · 2020-06-29T23:45:21Z

src/Components/Shared/Dashboard/Dashboard.scss

+    height: 65px;
+    background: #f7f7f7;
+  }
+  .content {


Line should be indented 0 spaces, but was indented 2 spaces

hound · 2020-06-29T23:45:22Z

src/Components/Shared/Dashboard/Dashboard.scss

+    z-index: 1;
+    height: 65px;
+    background: #f7f7f7;
+  }


Rule declaration should be followed by an empty line

brianineza01 temporarily deployed to champs-frontend-pr-15 June 23, 2020 18:54 Inactive

Agnes-N force-pushed the ft-approval-table-171648125 branch from 0fa254c to 7c4d791 Compare June 23, 2020 19:00

brianineza01 temporarily deployed to champs-frontend-pr-15 June 23, 2020 19:00 Inactive

Agnes-N force-pushed the ft-approval-table-171648125 branch from 7c4d791 to b29f360 Compare June 24, 2020 22:42

hound bot reviewed Jun 24, 2020

View reviewed changes

brianineza01 temporarily deployed to champs-frontend-pr-15 June 24, 2020 22:43 Inactive

Agnes-N force-pushed the ft-approval-table-171648125 branch from b29f360 to 3826437 Compare June 24, 2020 22:45

hound bot reviewed Jun 24, 2020

View reviewed changes

brianineza01 temporarily deployed to champs-frontend-pr-15 June 24, 2020 22:45 Inactive

Agnes-N force-pushed the ft-approval-table-171648125 branch from 3826437 to 5582460 Compare June 25, 2020 09:39

hound bot reviewed Jun 25, 2020

View reviewed changes

brianineza01 temporarily deployed to champs-frontend-pr-15 June 25, 2020 09:40 Inactive

171648125-approval-table: add approval table

10ec19d

- add approval table UI. [Finishes#171648125]

Agnes-N force-pushed the ft-approval-table-171648125 branch from 5582460 to 10ec19d Compare June 29, 2020 23:45

brianineza01 temporarily deployed to champs-frontend-pr-15 June 29, 2020 23:45 Inactive

hound bot reviewed Jun 29, 2020

View reviewed changes


		const basePath = "https://champs-bn-api.herokuapp.com/api/v1";

		export const approvalRequest = () => {


		@media (max-width: 1024px) {
		background-image: url(../../../../Assets/DashboardAssets/right.png);

171648125 Add approval table UI #15

Are you sure you want to change the base?

171648125 Add approval table UI #15

Conversation

Agnes-N commented Jun 23, 2020

Description

Type of change

How Has This Been Tested?

How to test?

Screnshoot?

STORY ID

hound bot Jun 24, 2020

Choose a reason for hiding this comment

hound bot Jun 24, 2020

Choose a reason for hiding this comment

hound bot Jun 24, 2020

Choose a reason for hiding this comment

hound bot Jun 24, 2020

Choose a reason for hiding this comment

hound bot Jun 24, 2020

Choose a reason for hiding this comment

hound bot Jun 24, 2020

Choose a reason for hiding this comment

hound bot Jun 24, 2020

Choose a reason for hiding this comment

hound bot Jun 24, 2020

Choose a reason for hiding this comment

hound bot Jun 24, 2020

Choose a reason for hiding this comment

hound bot Jun 24, 2020

Choose a reason for hiding this comment

hound bot Jun 24, 2020

Choose a reason for hiding this comment

hound bot Jun 24, 2020

Choose a reason for hiding this comment

hound bot Jun 24, 2020

Choose a reason for hiding this comment

hound bot Jun 24, 2020

Choose a reason for hiding this comment

hound bot Jun 24, 2020

Choose a reason for hiding this comment

hound bot Jun 24, 2020

Choose a reason for hiding this comment

hound bot Jun 24, 2020

Choose a reason for hiding this comment

hound bot Jun 24, 2020

Choose a reason for hiding this comment

hound bot Jun 24, 2020

Choose a reason for hiding this comment

hound bot Jun 24, 2020

Choose a reason for hiding this comment

hound bot Jun 25, 2020

Choose a reason for hiding this comment

hound bot Jun 25, 2020

Choose a reason for hiding this comment

hound bot Jun 25, 2020

Choose a reason for hiding this comment

hound bot Jun 25, 2020

Choose a reason for hiding this comment

hound bot Jun 25, 2020

Choose a reason for hiding this comment

hound bot Jun 25, 2020

Choose a reason for hiding this comment

hound bot Jun 25, 2020

Choose a reason for hiding this comment

hound bot Jun 25, 2020

Choose a reason for hiding this comment

hound bot Jun 25, 2020

Choose a reason for hiding this comment

hound bot Jun 25, 2020

Choose a reason for hiding this comment

hound bot Jun 29, 2020

Choose a reason for hiding this comment

hound bot Jun 29, 2020

Choose a reason for hiding this comment

hound bot Jun 29, 2020

Choose a reason for hiding this comment

hound bot Jun 29, 2020

Choose a reason for hiding this comment

hound bot Jun 29, 2020