#171784033 Feature resetpassword #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benshidanny11
requested review from
fordarnold,
bdushimi,
kabundege,
irfiacre and
Francois-MUGOROZI
benshidanny11
force-pushed
the
ft-resetpassword-171784033
branch
5 times, most recently
from
7c4ad8f to
56d8743
Compare
|
Daniel, could you use the same input fields used on Signup and login. |
benshidanny11
force-pushed
the
ft-resetpassword-171784033
branch
from
56d8743 to
d94f4a9
Compare
irfiacre
reviewed
Jun 17, 2020
| @@ -0,0 +1,22 @@ | |||
| import {RESET_ACTION,SEND_RESET_EMAIL_ACTION,SEND_RESET_EMAIL_IN_PROGRESS,RESET_IN_PROGRESS} from './actionTypes'; | |||
| import axios from 'axios'; | |||
| const sendResetEmailAPILink='https://warriorz-staging.herokuapp.com/api/v1/password/forgot'; | |||
There was a problem hiding this comment.
For the sake of security, I think these two routes may be better if they were obtained from the environmental variables in the .env
There was a problem hiding this comment.
Also, try to resolve the conflicts and make sure everything is good.
irfiacre
reviewed
Jun 17, 2020
| /> | ||
| <div className="div-contaier"> | ||
| <Link | ||
| className={cx("btn","btn-cancel")} |
There was a problem hiding this comment.
When I try to test LINK, Jest gives me an error.
If you are facing a similar issue I think you could alternatively use window.location.assign('pathname') or use useHistory
This might be easier to test and I guess more efficient.
benshidanny11
force-pushed
the
ft-resetpassword-171784033
branch
2 times, most recently
from
0af8cd4 to
c91bff8
Compare
benshidanny11
force-pushed
the
ft-resetpassword-171784033
branch
from
c91bff8 to
ef4eba2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Description of Task to be completed?
How should this be manually tested?
What are the relevant pivotal tracker stories?
Screenshots
Send reset email screen shoot
Reset password screen shoot
