#171784041 Build the UI for User Role Settings

[fordarnold]

[irfiacre]

Nice work @fordarnold

However on the profile(sideBar), maybe if you could use the background color which is white, and highlight the active page. Plus place the icons as they should be, I think it would be better.

For the navBar, I like that you added some other links, maybe you could add also the signout icon to allow a user to sign out and space them accordingly.

In general, you could also use the designed background-color: #083B66 or from the _settings.scss: $baseBlue.

There is a way you may use the Figma icons

Just copy the code as svg and the paste the in a filename.svg to get the icon.

[benshidanny11]

Good job

[fordarnold]

For the navBar, I like that you added some other links, maybe you could add also the signout icon to allow a user to sign out and space them accordingly.

@irfiacre I believe the person working on the User Sign-Out feature should be responsible for adding the icon, functionality and tests. What do you think?

[fordarnold]

In general, you could also use the designed background-color: #083B66 or from the _settings.scss: $baseBlue.

Done 👍🏽

[fordarnold]

There is a way you may use the Figma icons...
Just copy the code as svg and the paste the in a filename.svg to get the icon.

Thanks for this great advice. I'm done implementing the icons.

[bdushimi]

Hey, @fordarnold good work so far. I have a few feedback/comments regarding the visual aspects.

1. The footer is not at the bottom of the page as it is supposed to be.
2. When signed in with the following credentials [Email: [email protected] Password: user@123], clicking on the View User Roles results into a blank page and errors in the console.
3. The UI is not yet responsive.
4. This route /dashboard should be protected, but it is not i.e. it can be accessed with or without a valid token. The expected behavior is redirection to the login page in the event there's no valid token.
5. The Make Trip Request link is not functional. It is supposed to be functional since Francois's PR/Make Trip Request feature has been merged.
6. Logged in as the admin, there's an excess of roles duplication. some role cards don't have edit & delete buttons
7. Logged in as the admin and edit a role:
   1. Before saving the changes, the system asks a role name which should not be the case.
   2. The save-changes and close-without-saving buttons should be aligned horizontally. Optionally centered.
   3. Let the save-button be active if and only if there is an updated checkbox and the close-without-changes be always active.
   4. Once a particular role's permissions changed/updated, upon the page refresh the changes are not reflected anymore.
   5. All roles have the same permissions
8. When a user is about to delete a particular role, I suggest to apply a background of red color on the YES, DELETE button and also give the NO, CANCEL as a background color as well.

I think it would be better to review the source codes after fixing the UI/functionality aspects of the feature.

[fordarnold]

6. Logged in as the admin, there's an excess of roles duplication. some role cards don't have edit & delete buttons

I've fixed the issue of duplicated Roles.

As for the role cards without edit/delete buttons... I was thinking that the Super Administrator role is a special type of role, and it should not be edited or deleted (i.e. if all other roles are deleted, only Super Admin should remain). Otherwise, the rest of the roles can be changed by a user with Super Administrator permissions. @bdushimi, What do you think about this?