Claude/physiological model validation 01 dn4 a yiktu9 bt lrr ar kd7y d

[STLNFTART]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
multi-heart-model	Ready	Preview	Comment	Nov 17, 2025 1:11am

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Add Node/DOM typings so regulatory TypeScript compiles

The new regulatory module sets lib to only "ES2022" and does not include any Node or DOM typings. The client code introduced in this commit uses fetch, setTimeout, and process.env (e.g., in clients/BaseClient.ts and FDAClient.ts). With the current config, tsc reports these globals as undefined and the package cannot build. Include the appropriate libs or types: ["node", "dom"] so npm run build succeeds.

Useful? React with 👍 / 👎.

[chatgpt-codex-connector]

FastAPI endpoints call non‑existent /reg-evidence HTTP service

Both regulatory routes issue HTTP requests to REGULATORY_SERVICE_URL/reg-evidence, but the TypeScript side of this commit only exposes an MCP server over stdio and never defines any HTTP handler for that path. In the current repository these calls will fail with connection errors, so the API router cannot fetch evidence as documented. Either add an HTTP server exposing /reg-evidence or adjust the Python integration to use the available interface.

Useful? React with 👍 / 👎.

[vercel]

The query method defaults to 'Tesla' when no vehicle identifier is provided, which will return Tesla-specific regulatory findings for incomplete requests.

View Details

📝 Patch Details

diff --git a/regulatory/clients/NHTSAClient.ts b/regulatory/clients/NHTSAClient.ts
index ddc4c2d..d6ce685 100644
--- a/regulatory/clients/NHTSAClient.ts
+++ b/regulatory/clients/NHTSAClient.ts
@@ -77,10 +77,11 @@ export class NHTSAClient extends BaseRegulatoryClient {
       endpoint = '/SafetyRatings/GetRecalls';
       url = `${this.config.baseUrl}${endpoint}?make=${nhtsaParams.make}&model=${nhtsaParams.model}&modelYear=${nhtsaParams.year}&format=json`;
     } else {
-      // Fallback: just search by make
-      endpoint = '/SafetyRatings/GetRecalls';
-      const make = nhtsaParams.make || 'Tesla'; // Default for demo
-      url = `${this.config.baseUrl}${endpoint}?make=${make}&format=json`;
+      // Cannot query without either VIN or complete make/model/year
+      throw new Error(
+        'Vehicle identification is required for NHTSA recall query. ' +
+        'Provide either: (1) VIN, or (2) make, model, and year'
+      );
     }
 
     const result = await this.executeRequest(endpoint, params, async () => {
@@ -135,12 +136,16 @@ export class NHTSAClient extends BaseRegulatoryClient {
    * Query vehicle complaints
    */
   async queryComplaints(params: NHTSAQueryParams): Promise<RegulatoryFinding[]> {
-    const endpoint = '/complaints/complaintsByVehicle';
-    const make = params.make || 'Tesla';
-    const model = params.model || 'Model 3';
-    const year = params.year || 2024;
+    // Require complete vehicle identification for complaints query
+    if (!params.make || !params.model || !params.year) {
+      throw new Error(
+        'Complete vehicle identification is required for NHTSA complaints query. ' +
+        'Provide: make, model, and year'
+      );
+    }
 
-    const url = `${this.config.baseUrl}${endpoint}?make=${make}&model=${model}&modelYear=${year}&format=json`;
+    const endpoint = '/complaints/complaintsByVehicle';
+    const url = `${this.config.baseUrl}${endpoint}?make=${params.make}&model=${params.model}&modelYear=${params.year}&format=json`;
 
     const result = await this.executeRequest(endpoint, params, async () => {
       const response = await fetch(url);
@@ -161,7 +166,7 @@ export class NHTSAClient extends BaseRegulatoryClient {
       category: 'vehicle_complaint',
       summary: complaint.summary?.substring(0, 300) || 'Complaint filed',
       severity: 'info' as EvidenceSeverity,
-      affectedProducts: [`${year} ${make} ${model}`],
+      affectedProducts: [`${params.year} ${params.make} ${params.model}`],
       dateIssued: complaint.dateComplaintFiled,
       referenceUrls: [],
       regulatoryIds: [complaint.odiNumber],
diff --git a/regulatory/service/RegulatoryEvidenceService.ts b/regulatory/service/RegulatoryEvidenceService.ts
index 9b4aa16..6f5d90f 100644
--- a/regulatory/service/RegulatoryEvidenceService.ts
+++ b/regulatory/service/RegulatoryEvidenceService.ts
@@ -117,28 +117,44 @@ export class RegulatoryEvidenceService {
     const findings: RegulatoryFinding[] = [];
 
     if (request.av) {
-      // Query NHTSA vehicle recalls
-      const nhtsaQuery = await this.nhtsaClient.query({
-        make: request.av.make,
-        model: request.av.model,
-        year: request.av.year,
-        vin: request.av.vin,
-      });
-      queries.push(nhtsaQuery);
-
-      if (nhtsaQuery.success) {
-        const nhtsaFindings = this.nhtsaClient.parseFindings({ Results: [] });
-        findings.push(...nhtsaFindings);
+      // Query NHTSA vehicle recalls only if vehicle identification is available
+      if (request.av.vin || (request.av.make && request.av.model && request.av.year)) {
+        try {
+          const nhtsaQuery = await this.nhtsaClient.query({
+            make: request.av.make,
+            model: request.av.model,
+            year: request.av.year,
+            vin: request.av.vin,
+          });
+          queries.push(nhtsaQuery);
+
+          if (nhtsaQuery.success) {
+            const nhtsaFindings = this.nhtsaClient.parseFindings({ Results: [] });
+            findings.push(...nhtsaFindings);
+          }
+        } catch (error) {
+          // Log error but continue - regulatory evidence is best-effort
+          console.warn(
+            `[RegulatoryEvidence] NHTSA recall query failed: ${error instanceof Error ? error.message : String(error)}`
+          );
+        }
       }
 
       // Query NHTSA complaints
       if (request.av.make && request.av.model && request.av.year) {
-        const complaints = await this.nhtsaClient.queryComplaints({
-          make: request.av.make,
-          model: request.av.model,
-          year: request.av.year,
-        });
-        findings.push(...complaints);
+        try {
+          const complaints = await this.nhtsaClient.queryComplaints({
+            make: request.av.make,
+            model: request.av.model,
+            year: request.av.year,
+          });
+          findings.push(...complaints);
+        } catch (error) {
+          // Log error but continue - regulatory evidence is best-effort
+          console.warn(
+            `[RegulatoryEvidence] NHTSA complaints query failed: ${error instanceof Error ? error.message : String(error)}`
+          );
+        }
       }
     }
 

Analysis

NHTSA query methods default to Tesla when vehicle identification is missing

What fails: NHTSAClient.query() and NHTSAClient.queryComplaints() silently default to querying for Tesla vehicles when required parameters are missing, returning regulatory findings for the wrong vehicle.

How to reproduce:

const client = new NHTSAClient();

// Without any parameters:
await client.query({});
// Makes request to: https://api.nhtsa.gov/SafetyRatings/GetRecalls?make=Tesla

await client.queryComplaints({});
// Makes request to: https://api.nhtsa.gov/complaints/complaintsByVehicle?make=Tesla&model=Model+3&modelYear=2024

// Via RegulatoryEvidenceService with empty av object:
const service = new RegulatoryEvidenceService();
await service.getEvidenceForRun({
  runId: 'test',
  domain: 'av',
  av: {} // Empty object, all properties undefined
});
// Also queries for Tesla recalls

Result: Queries executed with hardcoded Tesla defaults (lines 82, 139-141 in NHTSAClient.ts). Returns Tesla-specific regulatory findings even when caller provides no vehicle context.

Expected: Should require complete vehicle identification. Either:

• Throw error: "Vehicle identification (VIN or make/model/year) is required"
• Return empty results instead of defaulting to a specific manufacturer

Fix implemented:

• query() now throws error if neither VIN nor complete make/model/year is provided
• queryComplaints() now throws error if make/model/year is not all provided
• RegulatoryEvidenceService.getAVEvidence() now validates parameters before calling client methods and handles errors gracefully