Skip to content

Improve test import resilience and skip missing organchip deps#26

Merged
STLNFTART merged 1 commit intomainfrom
codex/run-all-repositories
Nov 28, 2025
Merged

Improve test import resilience and skip missing organchip deps#26
STLNFTART merged 1 commit intomainfrom
codex/run-all-repositories

Conversation

@STLNFTART
Copy link
Owner

Summary

  • add repository root to pytest pythonpath for top-level organ chip packages
  • ensure organ chip toxicity tests inject root/src paths and skip when organchip packages are unavailable

Testing

  • pytest (fails: expected integration/model assertions and missing optional modules; see log)

Codex Task

@vercel
Copy link
Contributor

vercel bot commented Nov 27, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
multi-heart-model Ready Ready Preview Comment Nov 27, 2025 5:44pm

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +88 to +89
trajectory, _ = suite.simulate_drug_exposure(
dose_mg=200.0,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid unpacking single-value simulate_drug_exposure

The new test unpacks simulate_drug_exposure into two variables, but OrganChipSuite.simulate_drug_exposure returns only a trajectory list, so this call will throw ValueError: not enough values to unpack before any assertions run. The same unpacking pattern is repeated in test_acetaminophen_gsh_depletion and test_circulation_distribution, meaning these tests will always error when pytest runs rather than exercising the toxicity logic.

Useful? React with 👍 / 👎.

@STLNFTART STLNFTART merged commit 4b2a78f into main Nov 28, 2025
3 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant