Improve test import resilience and skip missing organchip deps#26
Improve test import resilience and skip missing organchip deps#26
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| trajectory, _ = suite.simulate_drug_exposure( | ||
| dose_mg=200.0, |
There was a problem hiding this comment.
Avoid unpacking single-value simulate_drug_exposure
The new test unpacks simulate_drug_exposure into two variables, but OrganChipSuite.simulate_drug_exposure returns only a trajectory list, so this call will throw ValueError: not enough values to unpack before any assertions run. The same unpacking pattern is repeated in test_acetaminophen_gsh_depletion and test_circulation_distribution, meaning these tests will always error when pytest runs rather than exercising the toxicity logic.
Useful? React with 👍 / 👎.
Summary
Testing
Codex Task