forked from ChromeDevTools/devtools-frontend
-
Notifications
You must be signed in to change notification settings - Fork 0
[ImgBot] Optimize images #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
imgbot
wants to merge
1
commit into
main
Choose a base branch
from
imgbot
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pull bot
pushed a commit
that referenced
this pull request
Apr 1, 2025
On click NetworkLogItem of type DirectSocket now a new set of tabs is opened: ConnectionInfo, Initiator, Timing The related commit in chromium - https://chromium-review.googlesource.com/c/chromium/src/+/6308994 The previous commit in devtools that add NetworkManager logic - https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6316791/20 Design Document: go/chrome-devtools:directsockets-design How the UI looks like: 1. Direct Socket connection in Network manager log: https://screenshot.googleplex.com/6oorNNBQW3TWvWx.png. 2. Connection info tab Opening state: https://screenshot.googleplex.com/6SeiiJb5vQyVHKh.png. 3. Initiator tab: https://screenshot.googleplex.com/AXaNjTaX2MqJVGx.png. 4. Timing tab: https://screenshot.googleplex.com/3tofCoEdAat4tuC.png. Change-Id: I70ab6e80a163d39c287ac5e35293346e37239db4 Bug: 358327120 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6406321 Reviewed-by: Danil Somsikov <[email protected]> Reviewed-by: Changhao Han <[email protected]> Commit-Queue: Vlad Krot <[email protected]>
*Total -- 4,991.60kb -> 4,389.99kb (12.05%) /test/interactions/goldens/linux/dialog/button_dialog_closed_after_open.png -- 2.63kb -> 1.03kb (60.71%) /test/interactions/goldens/linux/dialog/shortcut_dialog_closed_after_open.png -- 2.63kb -> 1.03kb (60.71%) /test/interactions/goldens/linux/dialog/button_dialog_closed.png -- 2.63kb -> 1.03kb (60.71%) /test/interactions/goldens/linux/dialog/shortcut_dialog_closed.png -- 2.63kb -> 1.03kb (60.71%) /test/interactions/goldens/mac/select_menu/select_menu_with_groups.png -- 7.00kb -> 3.01kb (56.95%) /docs/styleguide/ux/images/button-icon-variations.png -- 8.59kb -> 3.73kb (56.57%) /docs/styleguide/ux/images/button-text-variations.png -- 29.17kb -> 12.87kb (55.87%) /test/interactions/goldens/win32/select_menu/select_menu_with_groups.png -- 5.23kb -> 2.37kb (54.7%) /docs/architecture_of_devtools_module_visibility_rules.png -- 42.06kb -> 20.15kb (52.09%) /docs/styleguide/ux/images/button-screenshot.png -- 3.56kb -> 1.73kb (51.28%) /docs/styleguide/ux/images/primary-buttons.png -- 11.22kb -> 5.49kb (51.13%) /docs/styleguide/ux/images/text-buttons.png -- 8.79kb -> 4.35kb (50.48%) /docs/styleguide/ux/images/tonal-buttons.png -- 11.29kb -> 5.61kb (50.29%) /docs/styleguide/ux/images/outlined-buttons.png -- 11.29kb -> 5.61kb (50.29%) /test/interactions/goldens/linux/direct_socket_connection_view/all_categories_closed.png -- 4.26kb -> 2.14kb (49.81%) /test/interactions/goldens/win32/dialog/top-left-open.png -- 3.52kb -> 1.78kb (49.51%) /test/interactions/goldens/win32/dialog/bottom-center-open.png -- 2.26kb -> 1.17kb (48.27%) /test/interactions/goldens/win32/dialog/bottom-auto-open.png -- 2.44kb -> 1.27kb (47.74%) /docs/styleguide/ux/images/sliders-variations.png -- 2.30kb -> 1.27kb (44.8%) /docs/checklist/images/checklist-application-trust-tokens.png -- 109.00kb -> 60.26kb (44.72%) /test/interactions/goldens/win32/explain/console_insight.png -- 17.19kb -> 9.81kb (42.96%) /test/interactions/goldens/win32/dialog/narrow-top-auto-open.png -- 2.24kb -> 1.31kb (41.66%) /test/interactions/interactive/no-diff-available.png -- 16.41kb -> 9.78kb (40.4%) /test/interactions/goldens/mac/dialog/narrow-top-auto-open.png -- 3.12kb -> 1.94kb (37.97%) /test/interactions/goldens/mac/dialog/bottom-auto-open.png -- 2.99kb -> 1.88kb (37.08%) /test/interactions/goldens/mac/dialog/bottom-center-open.png -- 2.85kb -> 1.80kb (36.73%) /test/interactions/goldens/mac/explain/console_insight.png -- 30.53kb -> 21.62kb (29.18%) /test/interactions/goldens/linux/performance/layout_shifts_track_dark_mode.png -- 3.82kb -> 2.75kb (28.14%) /docs/ecosystem/images/automatic_workspace_folders_flags.png -- 87.43kb -> 64.74kb (25.96%) /test/interactions/goldens/linux/performance/other-thread.png -- 2.95kb -> 2.19kb (25.75%) /test/interactions/goldens/linux/performance/timings_track_collapsed.png -- 2.92kb -> 2.19kb (24.85%) /test/interactions/goldens/linux/performance/timings_track_collapsed_dark_mode.png -- 2.89kb -> 2.19kb (24.25%) /test/interactions/goldens/linux/performance/interactions_track_collapsed.png -- 2.95kb -> 2.27kb (22.93%) /front_end/emulated_devices/iPad-landscape.svg -- 6.48kb -> 5.01kb (22.67%) /test/interactions/goldens/linux/performance/interactions_track_collapsed_dark_mode.png -- 2.90kb -> 2.24kb (22.66%) /test/interactions/goldens/linux/performance/rasterizer_tracks_collapsed.png -- 2.76kb -> 2.14kb (22.47%) /test/interactions/goldens/linux/performance/gpu_track_collapsed.png -- 3.22kb -> 2.51kb (22.26%) /test/interactions/goldens/linux/performance/gpu_track_expanded.png -- 3.22kb -> 2.51kb (22.26%) /test/interactions/goldens/mac/dialog/top-left-open.png -- 4.79kb -> 3.76kb (21.6%) /docs/styleguide/ux/images/radio-buttons-variations.png -- 7.76kb -> 6.15kb (20.74%) /test/interactions/goldens/linux/performance/timeline-expand-network-panel.png -- 102.23kb -> 83.60kb (18.23%) /test/interactions/goldens/linux/performance/timeline-expand-network-panel-and-select-event.png -- 105.00kb -> 85.93kb (18.16%) /front_end/ui/visual_logging/visual_logging_debugging.png -- 171.49kb -> 142.90kb (16.67%) /docs/images/debugging-unit-tests-with-vscode.png -- 161.37kb -> 135.60kb (15.97%) /docs/images/debugging-e2e-tests-with-vscode.png -- 123.98kb -> 104.87kb (15.41%) /test/interactions/goldens/linux/performance/timeline_canvas_scrolldown.png -- 67.25kb -> 57.17kb (14.99%) /front_end/emulated_devices/MotoG4-portrait.svg -- 21.53kb -> 18.31kb (14.97%) /front_end/emulated_devices/MotoG4-landscape.svg -- 21.66kb -> 18.44kb (14.88%) /test/interactions/goldens/linux/direct_socket_connection_view/all_categories_open.png -- 23.71kb -> 20.23kb (14.69%) /front_end/emulated_devices/iPhone6-landscape.svg -- 18.20kb -> 15.78kb (13.28%) /front_end/emulated_devices/iPhone6Plus-landscape.svg -- 21.17kb -> 18.43kb (12.95%) /test/interactions/goldens/linux/explain/console_insight.png -- 38.71kb -> 33.84kb (12.58%) /front_end/emulated_devices/iPhone6-portrait.svg -- 18.89kb -> 16.60kb (12.12%) /test/interactions/goldens/linux/direct_socket_connection_view/all_categories_open_values_absent.png -- 15.42kb -> 13.59kb (11.9%) /test/interactions/goldens/linux/performance/network_track_collapsed.png -- 7.05kb -> 6.22kb (11.76%) /docs/cookbook/images/devtools_on_devtools_starter.png -- 424.77kb -> 375.10kb (11.69%) /docs/styleguide/ux/images/glossary-panels.png -- 84.68kb -> 74.82kb (11.65%) /test/interactions/goldens/linux/performance/network_track_collapsed_dark_mode.png -- 7.07kb -> 6.25kb (11.59%) /test/interactions/goldens/linux/explain/console_insight_references.png -- 45.85kb -> 40.70kb (11.24%) /test/interactions/goldens/linux/explain/console_insight_reminder.png -- 29.51kb -> 26.27kb (10.95%) /test/interactions/goldens/linux/performance/bottomUp.png -- 29.88kb -> 26.61kb (10.95%) /front_end/emulated_devices/iPhone6Plus-portrait.svg -- 21.15kb -> 18.83kb (10.93%) /test/interactions/goldens/linux/performance/callTree.png -- 25.35kb -> 22.61kb (10.81%) /front_end/emulated_devices/iPhone5-landscape.svg -- 19.10kb -> 17.07kb (10.6%) /docs/images/gerrit-preview.png -- 26.40kb -> 23.60kb (10.59%) /docs/cookbook/images/devtools_on_devtools_automatic.png -- 247.97kb -> 221.97kb (10.48%) /test/interactions/goldens/linux/performance/network_track_expanded.png -- 148.81kb -> 133.51kb (10.28%) /front_end/emulated_devices/iPhone5-portrait.svg -- 15.21kb -> 13.66kb (10.2%) /test/interactions/goldens/linux/performance/insights-lcp-request-discovery.png -- 116.11kb -> 104.75kb (9.79%) /docs/styleguide/ux/images/combo-box-variations.png -- 8.67kb -> 7.84kb (9.64%) /test/interactions/goldens/linux/performance/network_track_expanded_dark_mode.png -- 149.00kb -> 135.10kb (9.33%) /test/interactions/goldens/linux/performance/timeline-before-extension-toggle.png -- 66.40kb -> 60.61kb (8.72%) /front_end/emulated_devices/Nexus5X-portrait.svg -- 1.79kb -> 1.64kb (8.09%) /test/interactions/goldens/linux/performance/timeline-after-extension-toggle.png -- 57.38kb -> 52.89kb (7.83%) /test/interactions/goldens/linux/performance/layout_shifts_track.png -- 3.74kb -> 3.45kb (7.77%) /docs/styleguide/ux/images/text-dodonts.png -- 53.12kb -> 49.04kb (7.68%) /test/interactions/goldens/linux/performance/timeline-long-task-candystripe.png -- 82.77kb -> 76.50kb (7.57%) /test/interactions/goldens/linux/performance/main-thread-long-task-candy-stripe.png -- 82.77kb -> 76.50kb (7.57%) /test/interactions/goldens/linux/performance/flame_chart_decorations.png -- 14.85kb -> 13.74kb (7.44%) /test/interactions/goldens/linux/explain/console_insight_optin.png -- 9.25kb -> 8.57kb (7.38%) /test/interactions/goldens/linux/ai_assistance/user_action_row.png -- 13.01kb -> 12.08kb (7.12%) /docs/policy/images/undocked-devtools.png -- 296.85kb -> 275.81kb (7.09%) /test/interactions/goldens/linux/performance/cpu-profile.png -- 78.24kb -> 72.78kb (6.99%) /test/interactions/goldens/linux/performance/timeline-overview-memory.png -- 13.31kb -> 12.39kb (6.92%) /docs/policy/images/devtools-gar-testing.png -- 262.16kb -> 244.19kb (6.86%) /test/interactions/goldens/linux/performance/cpu-profile-node.png -- 78.24kb -> 73.06kb (6.61%) /test/interactions/goldens/linux/performance/timeline-overview.png -- 11.57kb -> 10.84kb (6.3%) /test/interactions/goldens/linux/performance/main-thread-track.png -- 40.78kb -> 38.22kb (6.29%) /test/interactions/goldens/linux/protocol_monitor/advanced.png -- 19.95kb -> 18.73kb (6.1%) /test/interactions/goldens/linux/performance/history_dropdown.png -- 14.77kb -> 13.89kb (5.97%) /test/interactions/goldens/linux/performance/interactions_track_long_interactions.png -- 4.96kb -> 4.69kb (5.47%) /test/interactions/goldens/linux/performance/animations_track_collapsed_dark_mode.png -- 2.86kb -> 2.71kb (5.15%) /test/interactions/goldens/linux/performance/multiple_initiators.png -- 15.61kb -> 14.83kb (5%) /test/interactions/goldens/linux/performance/interactions_track.png -- 3.44kb -> 3.29kb (4.48%) /test/interactions/goldens/linux/protocol_monitor/basic.png -- 23.46kb -> 22.53kb (3.95%) /docs/styleguide/ux/images/button-multiple-primary.png -- 9.55kb -> 9.17kb (3.94%) /test/interactions/goldens/linux/performance/animations_track_expanded_dark_mode.png -- 3.17kb -> 3.04kb (3.86%) /test/interactions/goldens/linux/performance/animations_track_collapsed.png -- 2.85kb -> 2.75kb (3.83%) /test/interactions/goldens/linux/performance/interactions_track_expanded_dark_mode.png -- 3.38kb -> 3.27kb (3.32%) /docs/styleguide/ux/images/glossary-labeled-bookmarks.jpg -- 185.40kb -> 179.71kb (3.07%) /docs/styleguide/ux/images/button-confirmation-dialog.png -- 25.46kb -> 24.69kb (3.02%) /test/interactions/goldens/linux/performance/timeline-overview-long-task-red-bar.png -- 4.32kb -> 4.19kb (2.96%) /front_end/Images/src/align-content-space-around.svg -- 0.35kb -> 0.34kb (2.8%) /test/interactions/goldens/linux/performance/worker-track.png -- 53.50kb -> 52.04kb (2.74%) /docs/images/debugging-unit-tests-with-devtools.png -- 120.88kb -> 117.86kb (2.49%) /docs/styleguide/ux/images/icon-dodonts.png -- 63.59kb -> 62.03kb (2.46%) /test/interactions/goldens/linux/performance/timeline-overview-resizers.png -- 4.25kb -> 4.15kb (2.41%) /docs/styleguide/ux/images/primary-dodonts.png -- 181.80kb -> 177.54kb (2.34%) /test/interactions/goldens/linux/performance/rasterizer_tracks_expanded.png -- 11.92kb -> 11.66kb (2.24%) /test/interactions/goldens/linux/performance/animations_track_expanded.png -- 3.14kb -> 3.08kb (2.02%) /test/interactions/goldens/linux/performance/extension_palette.png -- 10.93kb -> 10.76kb (1.61%) /test/interactions/goldens/linux/performance/timeline-overview-busy-network.png -- 5.79kb -> 5.71kb (1.4%) /test/interactions/goldens/linux/performance/rasterizer-track.png -- 12.00kb -> 11.86kb (1.15%) /test/interactions/goldens/linux/performance/timeline-web-dev-screenshot-frames.png -- 119.00kb -> 117.75kb (1.05%) /front_end/Images/src/difference.svg -- 0.61kb -> 0.61kb (0.64%) /test/interactions/goldens/linux/performance/main-thread-track-candy-stripe.png -- 37.72kb -> 37.52kb (0.54%) /docs/architecture_of_devtools_lazy_loading_features.png -- 50.10kb -> 49.85kb (0.5%) /front_end/Images/src/arrow-up-down-circle.svg -- 1.38kb -> 1.38kb (0.28%) /test/interactions/goldens/linux/dialog/bottom-center-open.png -- 2.53kb -> 2.52kb (0.15%) /test/interactions/goldens/linux/performance/timeline.png -- 27.58kb -> 27.56kb (0.07%) Signed-off-by: ImgBotApp <[email protected]>
pull bot
pushed a commit
that referenced
this pull request
Apr 24, 2025
This adds support for evaluating <percentage> units in css value tracing, but only for longhands. For shorthands, we need additional reasoning about which longhand the unit pertains to in order to understand whether it's relative to a width or a height. Bug: 401213719 Change-Id: I1b519f95c1cdd56226f4dcfc08c85147cc820578 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6459222 Reviewed-by: Eric Leese <[email protected]> Commit-Queue: Philip Pfaffe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beep boop. Your images are optimized!
Your image file size has been reduced by 12% 🎉
Details
📝 docs |
repo | 🙋🏾 issues | 🏪 marketplace
~Imgbot - Part of Optimole family