Implement confirmation dialog for deleting items#110
Draft
elliotwutingfeng wants to merge 8 commits intoSUPERCILEX:masterfrom
Draft
Implement confirmation dialog for deleting items#110elliotwutingfeng wants to merge 8 commits intoSUPERCILEX:masterfrom
elliotwutingfeng wants to merge 8 commits intoSUPERCILEX:masterfrom
Conversation
Owner
|
Can you extract the readme changes into another PR? I'd like to accept that right away. |
Contributor
Author
Done. There is still the locale which has not been updated yet. |
SUPERCILEX
requested changes
Aug 18, 2024
| ) { | ||
| const next = entry.next; | ||
| this._removeEntry(entry, true); | ||
| this._confirmRemoveEntry(entry, true); |
Owner
There was a problem hiding this comment.
This is not something caused by a user action, undo.
| last.text.startsWith(text)) | ||
| ) { | ||
| this._removeEntry(last, true); | ||
| this._confirmRemoveEntry(last, true); |
|
|
||
| _deleteEntryAndRestoreLatest(entry) { | ||
| this._removeEntry(entry, true, true); | ||
| this._confirmRemoveEntry(entry, true, true); |
Owner
There was a problem hiding this comment.
Not correct either because this shouldn't trigger a confirmation:
gnome-clipboard-history/extension.js
Line 914 in d437412
I think you need to take in an optional confirm param.
| </description> | ||
| </key> | ||
|
|
||
| <key name="confirm-remove-favorite" type="b"> |
Owner
There was a problem hiding this comment.
These settings need to be supported in code (prefs.js).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #109
Changes
Help wanted