Release/6.2 #1404
Draft
Release/6.2 #1404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, when saving a test entity, the contractual base field in manage would be set to null. This is because the contractual base field is used for the production entities. Other random coin fields will not get overwritten. This change makes sure the current value from Manage is reapplied, so sp-dasboard will not mutate the value. Fixes #1343 (cherry picked from commit e548d94)
Fix: Contractual base gets overwritten in manage
Prior to this change, when a change request was sent, the contractualBase would be set to null, because it is not present in the form. This change updates the contractual base if necessary on update. The expected behaviour is: When the field is not present, add it with the correct value When the field is present and the value is incorrect update it When the field is present and the value is correct, leave it untouched Resolves #1343 (cherry picked from commit 0085f9a)
…6.2-cherrypick Fix: Don't reset contractual base on production entities
Prior to this change, an error occurred looking up jira issues, resulting in jira issues not being created. By updating this library, error should no longer occur as this version of the library does not do strict type checking. #1364
Fix? for Jira tickets not being created
Jira is updated and now returns null for the 'expand' field.
Experimental fix for Jira issue.
…imental_fix merge upstream experimental fix
The previous commit does not use the correct version of the jira bundle, it did not include the previous fix. This commit fixes that, including all fixes.
Fix previous commit regression
Prior to this change, parsing the response from manage failed because manage changed the output. This change adapts to the new format so no incorrect error messages are shown. Fixes #1382
…sponse Adapt to updated manage response
This should make sure that the NameIDFormat is required when using a metadata url to load an entity. (cherry picked from commit 62a6c05)
(cherry picked from commit 5f5a106)
The secret modal should not be visible when it's a public client.
This is done so Manages knows the secret should be null
…null_as_secret_when_public_client Send null secret to manage for public client RP's
…dal_when_public_client Prevent client secret modal when public client
This reverts commit 5231333.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.