-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't use the full registry url in FROM on Tumbleweed #1700
Conversation
Created a staging project on OBS for Tumbleweed: home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-1700 Build ResultsRepository
Repository
Repository
Repository
Build succeeded ✅ To run BCI-tests against this PR, use the following command: OS_VERSION=tumbleweed TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/tumbleweed/tumbleweed-1700/ tox -- -n auto The following images can be pulled from the staging project:
|
src/bci_build/package/__init__.py
Outdated
f"FROM {self._from_image} AS builder" | ||
) | ||
# use the full registry URL in FROM on SLE, | ||
# but on TW we must not do this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: why not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because DimStar doesn't like it and keeps declining our containers: https://build.opensuse.org/request/show/1202139
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the reason is not "doesn't like it" but the reason is "we don't want to have a rebuild triggered from outside openSUSE:Factory" which seems not entirely valid because this is not a source change and Factory is on rebuild=local only.
I keep discussing this. anyhow we should capture the actual reason in the commit message so that we can go back to it when / if this needs to be revisited.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have we tried talking to dimstar?
The Tumbleweed team doesn't want to have an external dependency (e.g. registry) in staging or Factory.
34e9080
to
df148a2
Compare
updated commit message and merging due to unresolved discussion with tw team |
This is discouraged in TW: https://build.opensuse.org/request/show/1202139