Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use the full registry url in FROM on Tumbleweed #1700

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

dcermak
Copy link
Collaborator

@dcermak dcermak commented Sep 20, 2024

dcermak pushed a commit that referenced this pull request Sep 20, 2024
Copy link

github-actions bot commented Sep 20, 2024

Created a staging project on OBS for Tumbleweed: home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-1700
Changes pushed to branch Tumbleweed-1700 as commit 13bb7387a213394de34467ccbf1a88b67f8a4eca
Build succeeded ✅

Build Results

Repository images in home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-1700 for x86_64: current state: published
Build results:

package name status build log
apache-tomcat-10-java-17-image ⛔ excluded live log
apache-tomcat-10-java-21-image ⛔ excluded live log
apache-tomcat-10-java-22-image ⛔ excluded live log
apache-tomcat-9-java-17-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-1700 for aarch64: current state: published
Build results:

package name status build log
apache-tomcat-10-java-17-image ⛔ excluded live log
apache-tomcat-10-java-21-image ⛔ excluded live log
apache-tomcat-10-java-22-image ⛔ excluded live log
apache-tomcat-9-java-17-image ⛔ excluded live log

Repository containerfile in home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-1700 for x86_64: current state: published
Build results:

package name status build log
apache-tomcat-10-java-17-image ✅ succeeded live log
apache-tomcat-10-java-21-image ✅ succeeded live log
apache-tomcat-10-java-22-image ✅ succeeded live log
apache-tomcat-9-java-17-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-1700 for aarch64: current state: published
Build results:

package name status build log
apache-tomcat-10-java-17-image ✅ succeeded live log
apache-tomcat-10-java-21-image ✅ succeeded live log
apache-tomcat-10-java-22-image ✅ succeeded live log
apache-tomcat-9-java-17-image ✅ succeeded live log

Build succeeded ✅

To run BCI-tests against this PR, use the following command:

OS_VERSION=tumbleweed TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/tumbleweed/tumbleweed-1700/ tox -- -n auto
The following images can be pulled from the staging project:
  • registry.opensuse.org/home/defolos/bci/staging/tumbleweed/tumbleweed-1700/containerfile/opensuse/apache-tomcat:latest

f"FROM {self._from_image} AS builder"
)
# use the full registry URL in FROM on SLE,
# but on TW we must not do this
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: why not?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because DimStar doesn't like it and keeps declining our containers: https://build.opensuse.org/request/show/1202139

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the reason is not "doesn't like it" but the reason is "we don't want to have a rebuild triggered from outside openSUSE:Factory" which seems not entirely valid because this is not a source change and Factory is on rebuild=local only.

I keep discussing this. anyhow we should capture the actual reason in the commit message so that we can go back to it when / if this needs to be revisited.

Copy link
Member

@dirkmueller dirkmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have we tried talking to dimstar?

The Tumbleweed team doesn't want to have an external dependency
(e.g. registry) in staging or Factory.
@dirkmueller
Copy link
Member

updated commit message and merging due to unresolved discussion with tw team

@dirkmueller dirkmueller merged commit 3df2400 into main Sep 23, 2024
9 checks passed
@dirkmueller dirkmueller deleted the no-full-registry-on-tw branch September 23, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants