Simplify test code given the changes from pytest_container#216#726
Draft
Simplify test code given the changes from pytest_container#216#726
Conversation
dcermak
force-pushed
the
inherit-marks
branch
6 times, most recently
from
6e4cc05 to
419bb28
Compare
Member
alexandrevicenzi
left a comment
alexandrevicenzi
left a comment
There was a problem hiding this comment.
Overall, looks a lot cleaner 👍
dirkmueller
previously approved these changes
Jan 27, 2025
dcermak
force-pushed
the
inherit-marks
branch
2 times, most recently
from
3b33a5b to
84fdb17
Compare
dcermak
force-pushed
the
inherit-marks
branch
2 times, most recently
from
6770ba2 to
8f00e81
Compare
Member
|
@dcermak can you rebase and mark it as ready for review please? |
We now no longer have to perform the manual container & mark unbundling as Container and DerivedContainer are now instances of ParameterSet as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now no longer have to perform the manual container & mark unbundling as
ContainerandDerivedContainerare now instances ofParameterSetas wellSee also dcermak/pytest_container#216