Skip to content

Adding tests for AI pytorch container #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chajain wants to merge 1 commit into from
Closed

Adding tests for AI pytorch container #752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions bci_tester/data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1029,6 +1029,13 @@ def create_BCI(
custom_entry_point="/bin/bash",
)

PYTORCH_CONTAINER = create_BCI(
build_tag=f"{SAC_CONTAINER_PREFIX}/pytorch:2.5.0",
Copy link
Copy Markdown
Contributor

@dcermak dcermak Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will have to bump this string on every version bump in pytorch, which seems extremely wasteful to me. Can you use a more generic tag? Or are you really expecting to stay at 2.5.0 for an extended period of time?

bci_type=ImageType.SAC_APPLICATION,
available_versions=["15.6-ai"],
custom_entry_point="/bin/bash",
)

STUNNEL_CONTAINER = create_BCI(
build_tag=f"{APP_CONTAINER_PREFIX}/stunnel:5",
bci_type=ImageType.APPLICATION,
Expand Down Expand Up @@ -1112,6 +1119,7 @@ def create_BCI(
MINIMAL_CONTAINER,
OLLAMA_CONTAINER,
MILVUS_CONTAINER,
PYTORCH_CONTAINER,
*POSTFIX_CONTAINERS,
*TOMCAT_CONTAINERS,
*POSTGRESQL_CONTAINERS,
Expand Down Expand Up @@ -1157,6 +1165,7 @@ def create_BCI(
OLLAMA_CONTAINER,
OPENWEBUI_CONTAINER,
MILVUS_CONTAINER,
PYTORCH_CONTAINER,
]
+ BASE_FIPS_CONTAINERS
+ CONTAINER_389DS_CONTAINERS
Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ markers = [
'python_3.12',
'python_3.13',
'python_3.6',
'pytorch_2.5.0',
'registry_2.8',
'ruby_2.5',
'ruby_3.4',
Expand Down
23 changes: 22 additions & 1 deletion tests/test_ai.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,14 @@
from bci_tester.data import MILVUS_CONTAINER
from bci_tester.data import OLLAMA_CONTAINER
from bci_tester.data import OPENWEBUI_CONTAINER
from bci_tester.data import PYTORCH_CONTAINER

CONTAINER_IMAGES = (OLLAMA_CONTAINER, OPENWEBUI_CONTAINER, MILVUS_CONTAINER)
CONTAINER_IMAGES = (
OLLAMA_CONTAINER,
OPENWEBUI_CONTAINER,
MILVUS_CONTAINER,
PYTORCH_CONTAINER,
)


@pytest.mark.parametrize(
Expand Down Expand Up @@ -71,3 +77,18 @@ def test_milvus_health(container_per_test):
)
container_per_test.connection.check_output("etcd --version")
container_per_test.connection.check_output("milvus")


@pytest.mark.parametrize(
"container",
[PYTORCH_CONTAINER],
indirect=["container"],
)
def test_pytorch_health(container):
"""Test the pytorch container."""

# chech pytorch Version
container.connection.check_output(
"python3.11 -c 'import torch; print(torch.__version__)'"
)
container.connection.check_output("git --version")
2 changes: 2 additions & 0 deletions tests/test_metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@
from bci_tester.data import POSTGRESQL_CONTAINERS
from bci_tester.data import PROMETHEUS_CONTAINERS
from bci_tester.data import PYTHON_CONTAINERS
from bci_tester.data import PYTORCH_CONTAINER
from bci_tester.data import RUBY_CONTAINERS
from bci_tester.data import RUST_CONTAINERS
from bci_tester.data import SAC_PYTHON_CONTAINERS
Expand Down Expand Up @@ -277,6 +278,7 @@ def _get_container_label_prefix(
(OLLAMA_CONTAINER, "ollama", ImageType.SAC_APPLICATION),
(OPENWEBUI_CONTAINER, "open-webui", ImageType.SAC_APPLICATION),
(MILVUS_CONTAINER, "milvus", ImageType.SAC_APPLICATION),
(PYTORCH_CONTAINER, "pytorch", ImageType.SAC_APPLICATION),
]
+ [(STUNNEL_CONTAINER, "stunnel", ImageType.APPLICATION)]
+ [
Expand Down
Loading