Disable wordexp on Windows where it is unavailable#155
Merged
giulianobelinassi merged 1 commit intoSUSE:mainfrom Oct 9, 2025
Merged
Disable wordexp on Windows where it is unavailable#155giulianobelinassi merged 1 commit intoSUSE:mainfrom
giulianobelinassi merged 1 commit intoSUSE:mainfrom
Conversation
The wordexp() function is a POSIX extension not available on Windows. This patch conditionally compiles wordexp usage only on non-Windows platforms. On Windows, the path is used as-is without shell expansion, since Windows does not support tilde expansion in the same way as POSIX systems. Changes: - Wrap #include <wordexp.h> with #ifndef _WIN32 - Add platform-specific constructor implementations - Windows version simply stores the path without expansion
Collaborator
|
Looks fine to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mingw does not provide
wordexp(and neither does MSVC for that matter). In general though, windows programs (outside of specific exceptions likebash) are not expected to perform shell expansion, so just disable this feature under windows.AI disclaimer: Written by Claude Code.