azure: support Hub/Spoke network architecture and add Fortinet deployment#763
Draft
yeoldegrove wants to merge 162 commits intoSUSE:developfrom
Draft
azure: support Hub/Spoke network architecture and add Fortinet deployment#763yeoldegrove wants to merge 162 commits intoSUSE:developfrom
yeoldegrove wants to merge 162 commits intoSUSE:developfrom
Conversation
arbulu89
requested changes
Sep 29, 2021
Collaborator
arbulu89
left a comment
There was a problem hiding this comment.
Many many comments.
I just checked the logic of the new code. I didn't check whether the terraform usage of the new components is correct or not, as it is pretty complex.
In any case, I miss some documentation in the terraform.tfvars.example file. This is the file most people use rather than the README file
0d3aa97 to
d97ff3e
Compare
arbulu89
reviewed
Oct 6, 2021
3194a74 to
ae1a6b0
Compare
cab6969 to
da84d5c
Compare
…fen/ha-sap-terraform-deployments into mayerhofen
…fen/ha-sap-terraform-deployments into develop-mayerhofen
…terraform-deployments into develop-mayerhofen
…terraform-deployments into mayerhofen
…fen/ha-sap-terraform-deployments into mayerhofen
…terraform-deployments into develop-mayerhofen
Develop mayerhofen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hub/Spoke Architecture
This adds support for Microsoft Azure's Hub/Spoke Architecture.
It does so by implementing a new variable
network_topologywhich is set toplain(current setup) by default.The new variable executes different terraform modules called
network_{plain,hub,spoke}which implement the different network scenarios.If
network_topology="hub_spoke"is set, the new hub/spoke scenario is deployed.A refernce to "Use Hub/Spoke network architecture" is in
README.mdand examples (to just uncomment) are interraform.tfvars.e.g.
plain network (default/current setup)
The plain network is still the default.
create hub + spoke network
To create both Hub/Spoke networks and a bastion host, set this in
terraform.tfvars:existing hub + create spoke network
To use an existing Hub network and bastion host and only deploy the Spoke network, set this in
terraform.tfvars:Fortinet Deployment