Merged
Conversation
Signed-off-by: Vincenzo Mezzela <vincenzo.mezzela@suse.com>
vmezzela
force-pushed
the
archs-build
branch
from
a55738d to
1c64471
Compare
Signed-off-by: Vincenzo Mezzela <vincenzo.mezzela@suse.com>
marcosps
approved these changes
Jan 2, 2026
Collaborator
marcosps
left a comment
marcosps
left a comment
There was a problem hiding this comment.
We have been changing the archs for Codestreams lately that things are still kind of broken in some places... thanks a lot for fixing it!
LGTM!
Collaborator
Author
|
Hi Marcos, before we merge, I will push another commit still related to this PR as I just realized we have the same issue during prepare-tests. |
marcosps
approved these changes
Jan 5, 2026
Collaborator
marcosps
left a comment
marcosps
left a comment
There was a problem hiding this comment.
That's good, thanks a lot for the fixes!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should build all archs even when the livepatch does not affect one of them to make sure that conditional compilation works.