Convert format-patches to plugins #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
vmezzela
force-pushed
the
format-patches-next
branch
from
b147a19 to
b9145f8
Compare
Done ✔️ |
vmezzela
force-pushed
the
format-patches-next
branch
2 times, most recently
from
a6e1bc3 to
09dc31f
Compare
Signed-off-by: Vincenzo MEZZELA <[email protected]>
When implementing a new command, we might want to have "-" in the name, see for instance the "format-patches" command. Unfortunately, we cannot have the "-" in a python file name. Hence we need to replace the symbol in the plugin loading machinery with "_" and then be consistent with the plugin file naming: "format-patches" command will have its own plugin named "format_patches.py" in the plugins package. Signed-off-by: Vincenzo MEZZELA <[email protected]>
Signed-off-by: Vincenzo MEZZELA <[email protected]>
vmezzela
force-pushed
the
format-patches-next
branch
from
09dc31f to
47101d8
Compare
marcosps
approved these changes
Feb 28, 2025
fgyanz
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, nothing special here. Just continuing the work of converting commands to the new plugin system.
I noticed that this command takes the argument
lp_filter, but never uses it. Should we just drop the option here?While on it, do you have any other suggestion to improve this plugin?