Convert setup to plugins #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcosps
reviewed
Feb 27, 2025
klpbuild/plugins/setup.py
Outdated
|
|
||
| def setup(lp_name, lp_filter, no_check, archs, cve, conf, module, file_funcs, | ||
| mod_file_funcs, conf_mod_file_funcs): | ||
| # TODO: make sure archs is an array |
There was a problem hiding this comment.
Maybe add a newline before the TODO?
There was a problem hiding this comment.
Sure I can, but this is changed right in the next commit. Do you want me to change it anyway?
|
@vmezzela this works as expected. Would you like to remove the draft status? |
|
Sure! |
Signed-off-by: Vincenzo MEZZELA <[email protected]>
Signed-off-by: Vincenzo MEZZELA <[email protected]>
Drop the Setup class and convert this command to a plugin. Convert also all the affected tests. Signed-off-by: Vincenzo MEZZELA <[email protected]>
Signed-off-by: Vincenzo MEZZELA <[email protected]>
fgyanz
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, another command converted to the plugin system.
There's no functional change, just moving code around.
I also converted all related tests and carefully verified their correctness, as the process was error-prone. Let me know if you spot anything I might have missed!