extract: Get gcc args by using compile_commands.json #96
Conversation
Our make strategy worked well until we found the a new way of getting the gcc arguments used to compile a kernel source file. Recently it started to fail on newer codestreams, failing to find the proper _source_ directory from the -obj directory. Use this opportunity to finally implement the arguments finding using compile_commands.json that is packaged by kernel-livepatch-default-livepatch-devel rpm. The paths are extactly the same being found using make, but the instead of the absolute paths to the source directory of the codestreams, the compile_commands.json used '../'. Replacing ../ by the source directory of the affected codestream fixes the problem. Signed-off-by: Marcos Paulo de Souza <[email protected]>
klpbuild/plugins/extractor.py
Outdated
|
|
||
| logging.error(f"Couldn't find cmdline for {fname}. Aborting") | ||
| logging.error("Couldn't find cmdline for %s. Aborting", fname) |
There was a problem hiding this comment.
Perhaps I'd rather not use here "Aborting", since if we don't find the command-line we're looking for in the json we just use the old method, right?
We could just emit a warning instead of an error, like:
| logging.error("Couldn't find cmdline for %s. Aborting", fname) | |
| logging.warning("Couldn't find cmdline for %s in compile_commands.json, using get_make_cmd().", fname) |
or something similar.
There was a problem hiding this comment.
We can do that, but we won't expect the make approach to work either, since compile_commands.json is created for each compiled source file. We can do what you suggested, but I won't expect to have more value from it.
There was a problem hiding this comment.
I agree with you on this, my concern is just that as far as I understand we're not aborting here. Unless I'm missing something
There was a problem hiding this comment.
Ouch, that's true. My bad. Thanks a lot for catching this issue! I believe that I should create one test for it, since it's easy to catch such issue!
Instead of returning errors on logging just return exceptions. This makes things more simple to understand. Also, return an error with a file cannot be found on compile_commands.json, since it means that we have an issue regarding the specific file. Signed-off-by: Marcos Paulo de Souza <[email protected]>
Signed-off-by: Marcos Paulo de Souza <[email protected]>
Our make strategy worked well until we found the a new way of getting the gcc arguments used to compile a kernel source file. Recently it started to fail on newer codestreams, failing to find the proper source directory from the -obj directory.
Use this opportunity to finally implement the arguments finding using compile_commands.json that is packaged by kernel-livepatch-default-livepatch-devel rpm.
The paths are extactly the same being found using make, but the instead of the absolute paths to the source directory of the codestreams, the compile_commands.json used '../'. Replacing ../ by the source directory of the affected codestream fixes the problem.