Replace sources rpms with kernel.git #99
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vincenzo MEZZELA <[email protected]>
This new kernel tree module is required to replace the source rpms. In this way, klp-build can no longer download the sources and can allocate a worktree on demand when needed. This reduces heavily the amount of disk space used by klp-build. Signed-off-by: Vincenzo MEZZELA <[email protected]>
Signed-off-by: Vincenzo MEZZELA <[email protected]>
The sources rpm are now replaced by the kernel tree worktree on demand. Signed-off-by: Vincenzo MEZZELA <[email protected]>
Calling get_src_dir from setup makes kernel_tree initializing the kernel worktree just to check for the presence of one file. Instead, we can just query git to check this for us, avoid numerous kernel worktree check out. Signed-off-by: Vincenzo MEZZELA <[email protected]>
Signed-off-by: Vincenzo MEZZELA <[email protected]>
Signed-off-by: Vincenzo MEZZELA <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request modify
klp-buildso that the extractions relies on thekernel.gitrepository instead of the sources rpms.Each source is no longer downloaded and extracted. Instead a worktree checked out to the respective git tag is created in place of the old source.
This means:
klp-buildno longer downloads the sources rpm for all supported codestreams. In this way, setting up the tool for the first time is less time/disk-space consuming .klp-build clean-sourceswill remove all the worktrees. This is useful when there are old trees that we no longer support.Possible issues:
If for any reason when the worktree creation is interrupted, there might be problem of integrity with the kernel sources. It is recommended to run
klp-build clean-sourcesand before the next extraction.With this PR, a new entry in the config is required,
kernel_dir, which contains the path to the git kernel repository (expanded tree).To test the PR it's better to use a new
data_dirto make sure we're not using old data.