Fix repo_url concatenation logic in importer#1431
Open
rmg0070 wants to merge 1 commit intoSUSE:masterfrom
Open
Fix repo_url concatenation logic in importer#1431rmg0070 wants to merge 1 commit intoSUSE:masterfrom
rmg0070 wants to merge 1 commit intoSUSE:masterfrom
Conversation
Replaced incorrect ends_with usage with Ruby's end_with?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced incorrect ends_with usage with Ruby's end_with?
Description
While running the SMT to RMT migration using:
rmt-data-import -d ./
a
NoMethodErrorwas encountered due to the use of the non-existentends_withmethod on a RubyString.Ruby provides
end_with?, notends_with.This caused the importer to fail while normalizing repository URLs.
This change replaces the incorrect method call with
end_with?, ensuring repository URLs are normalized correctly and preventing the runtime error during import.Related Issue / Ticket / Trello card: N/A (encountered during SMT → RMT migration)
How to test
rmt-data-import -d ./
NoMethodErroris raisedChange Type
Checklist
Review
Please review according to the SUSE code review guidelines:
https://github.com/SUSE/scc-docs/blob/master/team/workflow/code_review.md