Fix duplicate records dw

[jesusbv]

Description

When the client runs a registration multiple endpoints are called,
one of them is the system update while the products of the system are
being activated

if both endpoints callbacks write to the file, it generates duplicate
records

We could use the system update only to update the file to be exported
to DW but the problem is the information is not complete when the
endpoint is invoked, meaning there would be duplicate records using
that endpoint information because of how registration works

The propose change uses the product activate endpoint to populate the
file whenever there is a product activation or upgrade (for example,
registration) and system update would populate the file when is
invoked outside a registration

• Related Issue / Ticket / Trello card: bsc#1258943

How to test

Registration

Run registration on a instance for example SLES 15 SP7 PAYG`
in the file, there should be no duplicates, there should be 11 entries

System update

after > 3 min, on the same instance, run heartbeat command, and check the file:
there should be no duplicates but new 11 entries, identical to the previous ones
but with a different last_seen_at value

Single product activation

remove a product, add the product again, there should be no duplicates in the file

Change Type

Please select the correct option.

• Bug Fix (a non-breaking change which fixes an issue)
• New Feature (a non-breaking change which adds new functionality)
• Documentation Update (a change which only updates documentation)

Checklist

Please check off each item if the requirement is met.

• I have reviewed my own code and believe that it's ready for an external review.
• I have provided comments for any hard-to-understand code.
• I have documented the MANUAL.md file with any changes to the user experience.
• If my changes are non-trivial, I have added a changelog entry to notify users at package/obs/rmt-server.changes.

Review

Please check out our review guidelines
and get in touch with the author to get a shared understanding of the change.

[jesusbv]

this means that if a user runs heartbeat command right after registration, we would not write anything to the file

[digitaltom]

The attributes registered_at and last_seen_at are not initialized with the same value. Both get set independently with Time.zone.now in different places of the code.

https://github.com/SUSE/rmt/blob/master/app/models/system.rb#L25 vs
https://github.com/SUSE/rmt/blob/master/app/controllers/application_controller.rb#L26

You might want to set registered_at directly from the last_seen_at value to guarantee they match.

[jesusbv]

updated the check to be under 10 seconds difference between the two values for a registration