Draft
Conversation
Formatting changes auto generated by command `npx eslint --fix --max-warnings 2000 --ext .js,.ts,.vue .` ran after adding new rules to `pkg/suse-ai-rancher-ext/.eslintrc.js` to prevent even more formatting warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an initial set of linting warnings and formatting inconsistencies across the codebase. It primarily focuses on applying auto-fixable ESLint rules to improve code style and readability.
Key Changes in this commit:
ESLint Configuration Update:
pkg/suse-ai-rancher-ext/.eslintrc.jsto refine formatting rules for Vue templates.vue/max-attributes-per-lineto allow up to 3 attributes on a single line for better conciseness, while still enforcing single attributes for multiline elements.vue/singleline-html-element-content-newlineto prevent unnecessary line breaks within HTML elements.vue/html-indentto enforce consistent 2-space indentation in Vue templates.Automated Formatting Fixes: Applied
eslint --fixacross thepkg/suse-ai-rancher-ext/directory, resulting in numerous automatic formatting adjustments based on the updated ESLint rules. This includes changes to attribute placement, indentation, and line breaks in various.vue,.ts, and.jsfiles.Note: This is a draft PR. Further commits will be added to address the remaining linting warnings, which include:
no-consolewarnings,eqeqeqwarnings,no-unused-varswarnings,@typescript-eslint/no-explicit-anywarnings,@typescript-eslint/no-non-null-assertionwarnings.