Skip to content

style: apply eslint fixes for formatting#34

Draft
rewenila wants to merge 1 commit intoSUSE:mainfrom
rewenila:feature/lint-fixes
Draft

style: apply eslint fixes for formatting#34
rewenila wants to merge 1 commit intoSUSE:mainfrom
rewenila:feature/lint-fixes

Conversation

@rewenila
Copy link
Contributor

@rewenila rewenila commented Jan 6, 2026

Description

This PR addresses an initial set of linting warnings and formatting inconsistencies across the codebase. It primarily focuses on applying auto-fixable ESLint rules to improve code style and readability.

Key Changes in this commit:

  • ESLint Configuration Update:

    • Modified pkg/suse-ai-rancher-ext/.eslintrc.js to refine formatting rules for Vue templates.
    • Updated vue/max-attributes-per-line to allow up to 3 attributes on a single line for better conciseness, while still enforcing single attributes for multiline elements.
    • Disabled vue/singleline-html-element-content-newline to prevent unnecessary line breaks within HTML elements.
    • Explicitly set vue/html-indent to enforce consistent 2-space indentation in Vue templates.
  • Automated Formatting Fixes: Applied eslint --fix across the pkg/suse-ai-rancher-ext/ directory, resulting in numerous automatic formatting adjustments based on the updated ESLint rules. This includes changes to attribute placement, indentation, and line breaks in various .vue, .ts, and .js files.

Note: This is a draft PR. Further commits will be added to address the remaining linting warnings, which include: no-console warnings, eqeqeq warnings, no-unused-vars warnings, @typescript-eslint/no-explicit-any warnings, @typescript-eslint/no-non-null-assertion warnings.

Formatting changes auto generated by command `npx eslint --fix --max-warnings 2000 --ext .js,.ts,.vue .` ran after adding new rules to `pkg/suse-ai-rancher-ext/.eslintrc.js` to prevent even more formatting warnings.
@rewenila rewenila requested a review from gunamata January 6, 2026 16:29
@rewenila rewenila marked this pull request as draft January 6, 2026 16:29
@rewenila rewenila removed the request for review from gunamata January 6, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant