Merged
Conversation
Closed
chabowski
reviewed
Apr 17, 2025
Collaborator
chabowski
left a comment
chabowski
left a comment
There was a problem hiding this comment.
Hi Frank @fsundermeyer,
thanks for the PR, I think it looks good now, even if the script also changed the names of established SAP Notes names - but as these are just names and no URLs, and as we do not have access to counter-check them, all should be good and I am convinced the changes do not create issues. I will merge the PR now.
chabowski
reviewed
Apr 17, 2025
Collaborator
chabowski
left a comment
chabowski
left a comment
There was a problem hiding this comment.
And thanks for adding the fix for the inlines/empty elements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.