fix(remote): set aiohttp HTTP timeout based on command timeout#290
Open
dcloud347 wants to merge 1 commit into
Open
fix(remote): set aiohttp HTTP timeout based on command timeout#290dcloud347 wants to merge 1 commit into
dcloud347 wants to merge 1 commit into
Conversation
Add timeout param to _request() so the HTTP layer uses aiohttp.ClientTimeout instead of aiohttp's default 300s. run_in_session() sets http_timeout = action.timeout + 30s so the server-side command timeout always fires first, letting the normal session-reboot path handle the error instead of a torn connection. Change-Id: I3de291bb5cc630aa4b06356f15972c588b9c7ec8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add timeout param to _request() so the HTTP layer uses aiohttp.ClientTimeout instead of aiohttp's default 300s. run_in_session() sets http_timeout = action.timeout + 30s so the server-side command timeout always fires first, letting the normal session-reboot path handle the error instead of a torn connection.
Change-Id: I3de291bb5cc630aa4b06356f15972c588b9c7ec8