Thread local as dynamic so that threads will communicate status#8
Open
GavinMendelGleason wants to merge 1 commit intoSWI-Prolog:masterfrom
Open
Thread local as dynamic so that threads will communicate status#8GavinMendelGleason wants to merge 1 commit intoSWI-Prolog:masterfrom
GavinMendelGleason wants to merge 1 commit intoSWI-Prolog:masterfrom
Conversation
Member
|
Hmmm. There was a reason for the thread_local declarations. I was wondering what that could be. I think I know. One is to deal with test runs initiated by (re-)loading files which may happen concurrently. The other is for calls such as below to stress-test test suites that are supposed to be thread-safe. Seems this needs to be a bit more complicated, such that the helpers know the thread they are supporting and recording the (main) test thread-id with the passed, etc facts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The overall run_tests should fail if any test fails, but that requires that we coordinate book-keeping through the various predicates
passed/5,failed/4,failed_assertion/7etc. For now I've just re-declared them as dynamic rather than thread_local.