Open
Conversation
Extend the existing PGO infrastructure to support MSVC's two-phase PGO
workflow (/GL + /GENPROFILE, then /GL + /USEPROFILE).
Key changes:
- BuildType.cmake: Enable the PGO build type for MSVC, add PGO to
CMAKE_CONFIGURATION_TYPES for multi-config generators, define
C/CXX_FLAGS_PGO with /O2 base optimization, and map PGO to Release
for imported targets (vcpkg).
- PGO.cmake: Add PGO_GENERATE_LINK_FLAGS and PGO_USE_LINK_FLAGS
variables to separate compile flags (/GL) from link flags
(/LTCG /GENPROFILE, /LTCG /USEPROFILE). Use /FI instead of
-include for the PGO timestamp header on MSVC. Wire the new
link flags through generate_pgo_data() and use_pgo_data().
/GL is added per-target so utility tools (defatom, mkvmi) that run
during the build are unaffected. MSVC places .pgd and .pgc files
next to the output binary automatically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend PGO infrastructure to support MSVC's two-phase workflow.
See commit message for details.