Optionally use CORE-MATH correctly rounded elementary functions - #1510
Closed
ridgeworks wants to merge 7 commits into
Closed
Optionally use CORE-MATH correctly rounded elementary functions#1510ridgeworks wants to merge 7 commits into
ridgeworks wants to merge 7 commits into
Conversation
Option depends on flag HAVE_CRMATH. IF CORE-MATH not used, defers to local defintions of cr_xxx functions with explicit rounding. Always use explicitly rounded `lgamma` function based on comment in source repo: "The lgamma function is omitted because Windows' math.h does not provide signgam."
Member
|
Merged after some refactoring. Notably reuse the external dependency with as little as possible own code and pin the version by git HASH for security and reproducibility purposes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under control of CMake option USE_CRMATH (default=OFF), build a local copy of library containing a subset of CORE-MATH functions from repo https://github.com/indigobio/core-math-binary64.
If option is OFF, use existing explicitly rounded functions currently in pl-arith.c. (under control of O_ROUNDING_UP_DOWN).
Caveats: