Use the h5py low level API when reading dataset slices#311
Draft
jchelly wants to merge 8 commits intoSWIFTSIM:masterfrom
Draft
Use the h5py low level API when reading dataset slices#311jchelly wants to merge 8 commits intoSWIFTSIM:masterfrom
jchelly wants to merge 8 commits intoSWIFTSIM:masterfrom
Conversation
Contributor
Author
|
The test failure here seems to be due to overlapping ranges being selected in the test that tries to write a spatial subset of a SOAP catalogue. Will need to investigate why that happens and what the result should be. |
Contributor
Author
|
Relevant information if we do try to use hyperslab selections: https://forum.hdfgroup.org/t/quadratic-runtime-of-selecting-n-hyperslabs/12555 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of doing a separate read_direct() for each slice when cutting out a region, we can select all slices with H5Sselect_hyperslab() and then do a single H5Dread(). This might avoid some h5py overhead. See also #283.