Fixed bug regarding reset value #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 1, 2023 15:58
The relevant commit is in combine.c, function "add_latches_from_implementation", in which I think that there's a bug present concerning the reset value
|
I think this bug has to do with changes to the AIGER format. It should probably be investigated whether there are other changes that need to be made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think there's a bug in the function "add_latches_from_implementation", as afterwards the reset value might be different from the original, violating AIGER format specifications. There's more info in the comments in the function. Someone should look over this to make sure it works fine (formally). Upon request I can also give two files where the bug might occur.
I also updated the aiger toolset, added a gitignore and my autoformatter did some stuff, but that shouldn't be of any concern I think.