Adds new VAD parameters + some VAD tweaks #1386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Purfview
changed the title
Adds new VAD parameters: min_silence_at_max_speech: Minimum silence duration in ms which is used to avoid abrupt cuts when max_speech_duration_s is reached. use_max_poss_sil_at_max_speech: Whether to use the maximum possible silence at max_speech_duration_s or not. If not, the last silence is used.
MahmoudAshraf97
force-pushed
the
patch-6
branch
from
b592862 to
b8c8fe7
Compare
Set minimum speech duration to zero for flexibility.
MahmoudAshraf97
approved these changes
Nov 19, 2025
Contributor
Author
|
@MahmoudAshraf97 for what reason you set |
Collaborator
|
because the batched pipeline is tuned for min_speech_duration_ms to 0, I wouldn't change it without testing WER on a longform dataset |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new VAD parameters:
min_silence_at_max_speech: Minimum silence duration in ms which is used to avoid abrupt cuts when max_speech_duration_s is reached.
use_max_poss_sil_at_max_speech: Whether to use the maximum possible silence at max_speech_duration_s or not. If not, the last silence is used.
"min_silence_at_max_speech" previously was hardcoded = 98 ms
"use_max_poss_sil_at_max_speech" helps to avoid abrupt cuts
Relevant links:
snakers4/silero-vad#664
snakers4/silero-vad#710