Fixes broken export LD_LIBRARY_PATH cmd in README.md - #1459
Open
gregtzar wants to merge 1 commit into
Open
Conversation
Collaborator
|
Hi and thanks for the contribution, however, the correct place to fix this is in CTranslate 2, it should be able to accept the pypi packages without having to point it explicitly, then we can remove the wrong export completely |
Author
|
@MahmoudAshraf97 I see, that would certainly be ideal. Hopefully in the meantime though we could at least fix the import paths that are currently required so it doesn't confuse anyone else. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current cmd to export the
LD_LIBRARY_PATHgave the following error on my machine:This has been reported in issue: #1320 and this update fixes the error.
Reason: In recent versions of nvidia-cublas-cu12 and nvidia-cudnn-cu12, NVIDIA changed how these packages are structured. The submodules are namespaces or do not explicitly declare a file property anymore, returning None across the board.