Skip to content

Fix typo & only display erro_message when it's in the response #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Fix typo & only display erro_message when it's in the response #32

wants to merge 3 commits into from

Conversation

cino
Copy link
Contributor

@cino cino commented Dec 9, 2017

FIxes an issue where the response doesn't contain a 'error_message'. Solution would be to just return the Exception without it.

@SachinAgarwal1337
Copy link
Owner

@ricardocino This Looks good. Can you please make the PR in develop branch.

@cino cino changed the base branch from master to develop December 10, 2017 10:29
@cino cino mentioned this pull request Dec 10, 2017
Merged
@cino
Copy link
Contributor Author

cino commented Dec 10, 2017 •
edited
Loading

Sure, see #33 :)

@cino cino closed this Dec 10, 2017
@cino cino deleted the fix-bug-error-handling branch December 10, 2017 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cino @SachinAgarwal1337