Skip to content

Fix: prevent make.py from updating uv.lock (#387)#1216

Open
MarcosBorgesPhD wants to merge 3 commits into
Safety-Critical-Rust-Consortium:mainfrom
MarcosBorgesPhD:fix-387-make-py-uv-lock
Open

Fix: prevent make.py from updating uv.lock (#387)#1216
MarcosBorgesPhD wants to merge 3 commits into
Safety-Critical-Rust-Consortium:mainfrom
MarcosBorgesPhD:fix-387-make-py-uv-lock

Conversation

@MarcosBorgesPhD

Copy link
Copy Markdown
Contributor

Harmonize the way we run make.py to be cross-platform and prevent it from updating the uv.lock which results in a dirty git repo.

Replace the usage:

  • macOS/Linux: ./make.py
  • Windows: uv run make.py

With:

  • macOS/Linux/Windows: uv run --frozen make.py

Closes #387

Replace the direct usage of ./make.py with uv run --frozen make.py to
ensure dependencies remain locked during execution.
@netlify

netlify Bot commented Jul 8, 2026

Copy link
Copy Markdown

Deploy Preview for scrc-coding-guidelines failed.

Name Link
🔨 Latest commit 98e8187
🔍 Latest deploy log https://app.netlify.com/projects/scrc-coding-guidelines/deploys/6a5f1c0534d7290008551fc1

@MarcosBorgesPhD

Copy link
Copy Markdown
Contributor Author

@plaindocs, since I removed the shebang #!/usr/bin/env -S uv run from make.py, the Netlify build command (sh && ./make.py) will now fail.

Do you prefer to fix this on the Netlify side (by changing the build command), or should we keep the shebang in make.py?

@PLeVasseur

Copy link
Copy Markdown
Collaborator

Do you prefer to fix this on the Netlify side (by changing the build command), or should we keep the shebang in make.py?

I think we should fix this on the Netlify side, that feels more correct.

@MarcosBorgesPhD

MarcosBorgesPhD commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

I think we should fix this on the Netlify side, that feels more correct.

@PLeVasseur, @plaindocs, who can help us with the Netlify fix?

It is necessary to replace the calls ./make.py with uv run --frozen make.py.

Also, we need to update the spec.lock! How do we do it? Just send a PR with the updated version?

@plaindocs

Copy link
Copy Markdown
Collaborator

Netlify is a @PLeVasseur thing afaik.

Re updating the spec lock, yes, there are some docs

@PLeVasseur

Copy link
Copy Markdown
Collaborator

@JoelMarcey -- could you help us out with the Netlify update? 🙏

@MarcosBorgesPhD, @plaindocs -- could you give the instructions on what needs updating?

I see there's already some description up in this comment, but if @JoelMarcey has further questions, support here would be appreciated.

@plaindocs

Copy link
Copy Markdown
Collaborator

I believe that comment covers it. Happy to try to help if there are questions.

It would make it easier for other folks to help if we used a file based Netlify config instead of the Netlify UI.

@MarcosBorgesPhD

Copy link
Copy Markdown
Contributor Author

@JoelMarcey -- could you help us out with the Netlify update? 🙏

In this PR, we removed the shebang from make.py so it can be invoked consistently across OS. Netlify now needs to call it through uv with --frozen to avoid modifying uv.lock (Issue #387).

Please replace:

./make.py

with:

uv run --frozen make.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix make.py updating uv.lock

3 participants