Skip to content

Update organization and repository references to Safety-Critical-Rust-Consortium #1218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MarcosBorgesPhD wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update organization and repository references to Safety-Critical-Rust-Consortium #1218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
56ba648
Update repository and organization references to
MarcosBorgesPhD Jul 10, 2026
f1fcd19
test: update mock repo owner to Safety-Critical-Rust-Consortium
MarcosBorgesPhD Jul 10, 2026
860a925
Merge remote-tracking branch 'upstream/main' into fix-387-make-py-uv-…
MarcosBorgesPhD Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions .github/guideline-from-issue-tests/test_issue_01.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"url": "https://api.github.com/repos/rustfoundation/safety-critical-rust-coding-guidelines/issues/4",
"repository_url": "https://api.github.com/repos/rustfoundation/safety-critical-rust-coding-guidelines",
"labels_url": "https://api.github.com/repos/rustfoundation/safety-critical-rust-coding-guidelines/issues/4/labels{/name}",
"comments_url": "https://api.github.com/repos/rustfoundation/safety-critical-rust-coding-guidelines/issues/4/comments",
"events_url": "https://api.github.com/repos/rustfoundation/safety-critical-rust-coding-guidelines/issues/4/events",
"html_url": "https://github.com/rustfoundation/safety-critical-rust-coding-guidelines/issues/4",
"url": "https://api.github.com/repos/Safety-Critical-Rust-Consortium/safety-critical-rust-coding-guidelines/issues/4",
"repository_url": "https://api.github.com/repos/Safety-Critical-Rust-Consortium/safety-critical-rust-coding-guidelines",
"labels_url": "https://api.github.com/repos/Safety-Critical-Rust-Consortium/safety-critical-rust-coding-guidelines/issues/4/labels{/name}",
"comments_url": "https://api.github.com/repos/Safety-Critical-Rust-Consortium/safety-critical-rust-coding-guidelines/issues/4/comments",
"events_url": "https://api.github.com/repos/Safety-Critical-Rust-Consortium/safety-critical-rust-coding-guidelines/issues/4/events",
"html_url": "https://github.com/Safety-Critical-Rust-Consortium/safety-critical-rust-coding-guidelines/issues/4",
"id": 3104390263,
"node_id": "I_kwDOOMMjbs65CTx3",
"number": 4,
Expand Down Expand Up @@ -34,7 +34,7 @@
{
"id": 8703664686,
"node_id": "LA_kwDOOMMjbs8AAAACBsdiLg",
"url": "https://api.github.com/repos/rustfoundation/safety-critical-rust-coding-guidelines/labels/category:%20advisory",
"url": "https://api.github.com/repos/Safety-Critical-Rust-Consortium/safety-critical-rust-coding-guidelines/labels/category:%20advisory",
"name": "category: advisory",
"color": "ededed",
"default": false,
Expand All @@ -43,7 +43,7 @@
{
"id": 8703664688,
"node_id": "LA_kwDOOMMjbs8AAAACBsdiMA",
"url": "https://api.github.com/repos/rustfoundation/safety-critical-rust-coding-guidelines/labels/status:%20draft",
"url": "https://api.github.com/repos/Safety-Critical-Rust-Consortium/safety-critical-rust-coding-guidelines/labels/status:%20draft",
"name": "status: draft",
"color": "ededed",
"default": false,
Expand All @@ -52,7 +52,7 @@
{
"id": 8703664689,
"node_id": "LA_kwDOOMMjbs8AAAACBsdiMQ",
"url": "https://api.github.com/repos/rustfoundation/safety-critical-rust-coding-guidelines/labels/decidability:%20decidable",
"url": "https://api.github.com/repos/Safety-Critical-Rust-Consortium/safety-critical-rust-coding-guidelines/labels/decidability:%20decidable",
"name": "decidability: decidable",
"color": "ededed",
"default": false,
Expand All @@ -61,7 +61,7 @@
{
"id": 8703686409,
"node_id": "LA_kwDOOMMjbs8AAAACBse3CQ",
"url": "https://api.github.com/repos/rustfoundation/safety-critical-rust-coding-guidelines/labels/chapter:%20concurrency",
"url": "https://api.github.com/repos/Safety-Critical-Rust-Consortium/safety-critical-rust-coding-guidelines/labels/chapter:%20concurrency",
"name": "chapter: concurrency",
"color": "ededed",
"default": false,
Expand All @@ -70,7 +70,7 @@
{
"id": 8703686412,
"node_id": "LA_kwDOOMMjbs8AAAACBse3DA",
"url": "https://api.github.com/repos/rustfoundation/safety-critical-rust-coding-guidelines/labels/scope:%20crate",
"url": "https://api.github.com/repos/Safety-Critical-Rust-Consortium/safety-critical-rust-coding-guidelines/labels/scope:%20crate",
"name": "scope: crate",
"color": "ededed",
"default": false,
Expand All @@ -79,7 +79,7 @@
{
"id": 8703732885,
"node_id": "LA_kwDOOMMjbs8AAAACBshslQ",
"url": "https://api.github.com/repos/rustfoundation/safety-critical-rust-coding-guidelines/labels/accepted",
"url": "https://api.github.com/repos/Safety-Critical-Rust-Consortium/safety-critical-rust-coding-guidelines/labels/accepted",
"name": "accepted",
"color": "6AABE8",
"default": false,
Expand Down Expand Up @@ -107,7 +107,7 @@
"body": "### Chapter\n\nConcurrency\n\n### Guideline Title\n\ntest ga\n\n### Category\n\nAdvisory\n\n### Status\n\nDraft\n\n### Release Begin\n\n1.1.1\n\n### Release End\n\n1.1.1\n\n### FLS Paragraph ID\n\nfls_fsdjkfslkdfj\n\n### Decidability\n\nDecidable\n\n### Scope\n\nCrate\n\n### Tags\n\ntest gatest ga\n\n### Amplification\n\nhehehehe\n\n### Exception(s)\n\n_No response_\n\n### Rationale\n\ntest ga\n\n### Non-Compliant Example - Prose\n\ntest ga\n\n### Non-Compliant Example - Code\n\ndfhsdfkjshdfskdjhftest ga\n\n### Compliant Example - Prose\n\ntest ga\n\n### Compliant Example - Code\n\ntest ga",
"closed_by": null,
"reactions": {
"url": "https://api.github.com/repos/rustfoundation/safety-critical-rust-coding-guidelines/issues/4/reactions",
"url": "https://api.github.com/repos/Safety-Critical-Rust-Consortium/safety-critical-rust-coding-guidelines/issues/4/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
Expand All @@ -118,7 +118,7 @@
"rocket": 0,
"eyes": 0
},
"timeline_url": "https://api.github.com/repos/rustfoundation/safety-critical-rust-coding-guidelines/issues/4/timeline",
"timeline_url": "https://api.github.com/repos/Safety-Critical-Rust-Consortium/safety-critical-rust-coding-guidelines/issues/4/timeline",
"performed_via_github_app": null,
"state_reason": null
}
28 changes: 14 additions & 14 deletions .github/guideline-from-issue-tests/test_issue_02.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"url": "https://api.github.com/repos/rustfoundation/safety-critical-rust-coding-guidelines/issues/4",
"repository_url": "https://api.github.com/repos/rustfoundation/safety-critical-rust-coding-guidelines",
"labels_url": "https://api.github.com/repos/rustfoundation/safety-critical-rust-coding-guidelines/issues/4/labels{/name}",
"comments_url": "https://api.github.com/repos/rustfoundation/safety-critical-rust-coding-guidelines/issues/4/comments",
"events_url": "https://api.github.com/repos/rustfoundation/safety-critical-rust-coding-guidelines/issues/4/events",
"html_url": "https://github.com/rustfoundation/safety-critical-rust-coding-guidelines/issues/4",
"url": "https://api.github.com/repos/Safety-Critical-Rust-Consortium/safety-critical-rust-coding-guidelines/issues/4",
"repository_url": "https://api.github.com/repos/Safety-Critical-Rust-Consortium/safety-critical-rust-coding-guidelines",
"labels_url": "https://api.github.com/repos/Safety-Critical-Rust-Consortium/safety-critical-rust-coding-guidelines/issues/4/labels{/name}",
"comments_url": "https://api.github.com/repos/Safety-Critical-Rust-Consortium/safety-critical-rust-coding-guidelines/issues/4/comments",
"events_url": "https://api.github.com/repos/Safety-Critical-Rust-Consortium/safety-critical-rust-coding-guidelines/issues/4/events",
"html_url": "https://github.com/Safety-Critical-Rust-Consortium/safety-critical-rust-coding-guidelines/issues/4",
"id": 3104390263,
"node_id": "I_kwDOOMMjbs65CTx3",
"number": 4,
Expand Down Expand Up @@ -34,7 +34,7 @@
{
"id": 8703664686,
"node_id": "LA_kwDOOMMjbs8AAAACBsdiLg",
"url": "https://api.github.com/repos/rustfoundation/safety-critical-rust-coding-guidelines/labels/category:%20advisory",
"url": "https://api.github.com/repos/Safety-Critical-Rust-Consortium/safety-critical-rust-coding-guidelines/labels/category:%20advisory",
"name": "category: advisory",
"color": "ededed",
"default": false,
Expand All @@ -43,7 +43,7 @@
{
"id": 8703664688,
"node_id": "LA_kwDOOMMjbs8AAAACBsdiMA",
"url": "https://api.github.com/repos/rustfoundation/safety-critical-rust-coding-guidelines/labels/status:%20draft",
"url": "https://api.github.com/repos/Safety-Critical-Rust-Consortium/safety-critical-rust-coding-guidelines/labels/status:%20draft",
"name": "status: draft",
"color": "ededed",
"default": false,
Expand All @@ -52,7 +52,7 @@
{
"id": 8703664689,
"node_id": "LA_kwDOOMMjbs8AAAACBsdiMQ",
"url": "https://api.github.com/repos/rustfoundation/safety-critical-rust-coding-guidelines/labels/decidability:%20decidable",
"url": "https://api.github.com/repos/Safety-Critical-Rust-Consortium/safety-critical-rust-coding-guidelines/labels/decidability:%20decidable",
"name": "decidability: decidable",
"color": "ededed",
"default": false,
Expand All @@ -61,7 +61,7 @@
{
"id": 8703686409,
"node_id": "LA_kwDOOMMjbs8AAAACBse3CQ",
"url": "https://api.github.com/repos/rustfoundation/safety-critical-rust-coding-guidelines/labels/chapter:%20concurrency",
"url": "https://api.github.com/repos/Safety-Critical-Rust-Consortium/safety-critical-rust-coding-guidelines/labels/chapter:%20concurrency",
"name": "chapter: concurrency",
"color": "ededed",
"default": false,
Expand All @@ -70,7 +70,7 @@
{
"id": 8703686412,
"node_id": "LA_kwDOOMMjbs8AAAACBse3DA",
"url": "https://api.github.com/repos/rustfoundation/safety-critical-rust-coding-guidelines/labels/scope:%20crate",
"url": "https://api.github.com/repos/Safety-Critical-Rust-Consortium/safety-critical-rust-coding-guidelines/labels/scope:%20crate",
"name": "scope: crate",
"color": "ededed",
"default": false,
Expand All @@ -79,7 +79,7 @@
{
"id": 8703732885,
"node_id": "LA_kwDOOMMjbs8AAAACBshslQ",
"url": "https://api.github.com/repos/rustfoundation/safety-critical-rust-coding-guidelines/labels/accepted",
"url": "https://api.github.com/repos/Safety-Critical-Rust-Consortium/safety-critical-rust-coding-guidelines/labels/accepted",
"name": "accepted",
"color": "6AABE8",
"default": false,
Expand Down Expand Up @@ -107,7 +107,7 @@
"body": "### Chapter\n\nAssociated Items\n\n### Guideline Title\n\nRecursive function are not allowed\n\n### Category\n\nRequired\n\n### Status\n\nDraft\n\n### Release Begin\n\n1.3.0\n\n### Release End\n\nlatest\n\n### FLS Paragraph ID\n\nfls_vjgkg8kfi93\n\n### Decidability\n\nUndecidable\n\n### Scope\n\nSystem\n\n### Tags\n\nreduce-human-error\n\n### Amplification\n\nAny function shall not call itself directly or indirectly\n\n### Exception(s)\n\nRecursion may be permitted under the following conditions:\n- The recursion termination condition is simple, explicit, and well-defined.\n- The function calls itself directly, or with strictly limited and clearly documented indirection.\n- The maximum recursion depth is statically bounded and justified, ensuring no risk of stack overflow.\n- The rationale for using recursion, rather than iteration, is clearly documented and reviewed.\n- The code is accompanied by tests that exercise the recursion boundary conditions.\n\n### Rationale\n\nRecursive functions can easily cause stack overflows, which may result in exceptions or, in some cases, undefined behavior (typically some embedded systems). Although the Rust compiler supports [tail call optimization](https://en.wikipedia.org/wiki/Tail_call), this optimization is not guaranteed and depends on the specific implementation and function structure. There is an [open RFC to guarantee tail call optimization in the Rust compiler](https://github.com/phi-go/rfcs/blob/guaranteed-tco/text/0000-explicit-tail-calls.md), but this feature has not yet been stabilized. Until tail call optimization is guaranteed and stabilized, developers should avoid using recursive functions to prevent potential stack overflows and ensure program reliability.\n\n### Non-Compliant Example - Prose\n\nThe below function `concat_strings` is not complaint because it call itself and depending on depth of data provided as input it could generate an stack overflow exception or undefine behavior.\n\n### Non-Compliant Example - Code\n\n```rust\n// Recursive enum to represent a string or a list of `MyEnum`\nenum MyEnum {\n Str(String),\n List(Vec<MyEnum>),\n}\n\n// Concatenates strings from a nested structure of `MyEnum` using recursion.\nfn concat_strings(input: &[MyEnum]) -> String {\n let mut result = String::new();\n for item in input {\n match item {\n MyEnum::Str(s) => result.push_str(s),\n MyEnum::List(list) => result.push_str(&concat_strings(list)),\n }\n }\n result\n}\n```\n\n### Compliant Example - Prose\n\nThe following code implements the same functionality using iteration instead of recursion. The `stack` variable is used to maintain the processing context at each step of the loop. This approach provides explicit control over memory usage. If the stack grows beyond a predefined limit due to the structure or size of the input, the function returns an error rather than risking a stack overflow or out-of-memory exception. This ensures more predictable and robust behavior in resource-constrained environments.\n\n### Compliant Example - Code\n\n```rust\n// Recursive enum to represent a string or a list of `MyEnum`\nenum MyEnum {\n Str(String),\n List(Vec<MyEnum>),\n}\n\n/// Concatenates strings from a nested structure of `MyEnum` without using recursion.\n/// Returns an error if the stack size exceeds `MAX_STACK_SIZE`.\nfn concat_strings_non_recursive(input: &[MyEnum]) -> Result<String, &'static str> {\n const MAX_STACK_SIZE: usize = 1000;\n let mut result = String::new();\n let mut stack = Vec::new();\n\n // Add all items to the stack\n stack.extend(input.iter());\n\n while let Some(item) = stack.pop() {\n match item {\n MyEnum::Str(s) => result.insert_str(0, s),\n MyEnum::List(list) => {\n // Add list items to the stack\n for sub_item in list.iter() {\n stack.push(sub_item);\n if stack.len() > MAX_STACK_SIZE {\n return Err(\"Too big structure\");\n }\n }\n }\n }\n }\n Ok(result)\n}\n```",
"closed_by": null,
"reactions": {
"url": "https://api.github.com/repos/rustfoundation/safety-critical-rust-coding-guidelines/issues/4/reactions",
"url": "https://api.github.com/repos/Safety-Critical-Rust-Consortium/safety-critical-rust-coding-guidelines/issues/4/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
Expand All @@ -118,7 +118,7 @@
"rocket": 0,
"eyes": 0
},
"timeline_url": "https://api.github.com/repos/rustfoundation/safety-critical-rust-coding-guidelines/issues/4/timeline",
"timeline_url": "https://api.github.com/repos/Safety-Critical-Rust-Consortium/safety-critical-rust-coding-guidelines/issues/4/timeline",
"performed_via_github_app": null,
"state_reason": null
}
Loading
Loading