Defects vs subsets#127
Conversation
…n explicit Amplification section exists (instead, whatever paragraph immediately opens the guideline is just normative). We can continue to call it that but the subheading is not necessary.
Co-authored-by: Pete LeVasseur <plevasseur@gmail.com>
✅ Deploy Preview for scrc-coding-guidelines ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Thanks @AlexCeleste for the excellent additions! Could you take a look at the comments I left?
By the way -- I think I recall you saying the plan is to incorporate these examples more into the Style Guideline to help flesh it out. Was that right? In this PR or another?
I suppose then it would be quite helpful to use the examples to illustrate the difference between a defect and subset.
PLeVasseur
added this to the
Get some initial coding guidelines landed, get a sense of any challenges milestone
iglesias
left a comment
iglesias
left a comment
There was a problem hiding this comment.
I've checked the additions a few times over the past weeks and they look quite good to me overall.
PLeVasseur
left a comment
PLeVasseur
left a comment
There was a problem hiding this comment.
Left a couple of thoughts! Thanks a bunch for sweeping through and addressing comments @AlexCeleste
PLeVasseur
left a comment
PLeVasseur
left a comment
There was a problem hiding this comment.
Missed a comment. Realized we can also use the linking to the standard library for core and other standard library crates as well 🥳
PLeVasseur
left a comment
PLeVasseur
left a comment
There was a problem hiding this comment.
I think we're almost there! Last question about choice of ETF RFC 2119-styling on one section.
PLeVasseur
left a comment
PLeVasseur
left a comment
There was a problem hiding this comment.
Also -- seems as though the double backtick syntax for Guideline title isn't working here:
Could you either remove the backticks or look into how to get this to still render correctly as inline code?
…using non-markup for the time being)
There was a problem hiding this comment.
Thanks @AlexCeleste for these excellent examples and fleshing out the style guidelines!
0c2e50f
felix91gr
added
the
CERT C
6 participants
This adds a basic example of three kinds of guideline: