[Guideline] Do not invoke undefined behavior#175
Conversation
✅ Deploy Preview for scrc-coding-guidelines ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Hey @AchimKriso -- that's great hear The below issue is pretty squarely on me: Could I ask you to first open a coding guideline issue template issue and fill the fields in there? We'll then review it while it's an issue and if all looks good, assign a label Once the label is affixed, a GitHub Action will fire to create a PR for further detailed review. For revisions you'll be able to modify the contents of the issue, and we can re-fire the label to subsume the previous PR's contents with the revised version. -- I have a PR which should update the instructions to have this step included, but I've not gotten it merged yet. Apologies for that 🙏 The concept with having an issue => PR pipeline being that:
So again -- it's on me that this is not documented better, I need to get that PR updated and merged to reflect our planned process. -- The same request applies to #176 as well. |
|
@PLeVasseur Created #190 as suggested. Closing this PR. |
I felt motivated to write some rules about unsafety in Rust.
This rule (or a variant thereof) seems inevitable, since most coding standards I'm aware of have a similar rule: