replaced integer overflow rule with strong typing rule#234
Conversation
✅ Deploy Preview for scrc-coding-guidelines ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
felix91gr
added
the
coding guideline
While I review the other arithmetic rule: here you meant strong typing, right? |
right--fixed |
|
Reviewed in session 2025-12-03 While I try to work out where the right buttons are to make this a commit suggestion 😅 the main review comment from the session was that this should not overwrite the existing rule - once a GUI has been assigned to a rule, it should stay assigned to it, even after that rule is deleted or withdrawn. Instead it would be better to add the new content in a separate pass. This will also work better if we adopt the prior suggestion to put every rule in its own file. Then the new content won't need to know or think about the rule currently being overwritten at all - the decision to include them becomes completely independent. But we thought it was very important that GUIs should stay valid forever once assigned; that way, we don't need to know titles, we can inline a link to the GUI from a piece of text and it will stay in sync that way |
Interesting. I changed the IDs of things. Does this give us a new GUI? |
8454c19 to
17b3fa6
Compare
PLeVasseur
left a comment
PLeVasseur
left a comment
There was a problem hiding this comment.
Hey @rcseacord -- thanks for writing this up. I've left a few thoughts. Please take a look.
PLeVasseur
left a comment
PLeVasseur
left a comment
There was a problem hiding this comment.
Suggestion to make an example a bit more idiomatic
587f8bc
github-project-automation
Bot
moved this to Done
in [Safety Critical Rust Consortium Coding Guidelines] Work Items
JoelMarcey
moved this to Done
in [Safety Critical Rust Consortium Coding Guidelines] Work Items
6 participants
Integer overflow rule is obsolete as it was replaced by by this merged #220
Strong typing rule has been added