Skip to content

fix(reviewer-bot): clarify /release command behavior and guidance#410

Open
PLeVasseur wants to merge 1 commit into
Safety-Critical-Rust-Consortium:mainfrom
PLeVasseur:fix/issue-406-release-explicit
Open

fix(reviewer-bot): clarify /release command behavior and guidance#410
PLeVasseur wants to merge 1 commit into
Safety-Critical-Rust-Consortium:mainfrom
PLeVasseur:fix/issue-406-release-explicit

Conversation

@PLeVasseur

Copy link
Copy Markdown
Collaborator

Summary

  • make /release usage explicit everywhere the bot documents commands by splitting self release and triage release forms
  • improve /release failure messaging for non current reviewers with actionable guidance that points to /release @current-reviewer
  • add regression tests for guidance text, /commands output, and the confusing non current reviewer release paths

Testing

  • uv run ruff check --fix scripts/reviewer_bot.py .github/reviewer-bot-tests/test_reviewer_bot.py
  • uv run python -m pytest .github/reviewer-bot-tests/test_reviewer_bot.py -k release
  • uv run python -m pytest .github/reviewer-bot-tests/test_reviewer_bot.py

Closes #406

@netlify

netlify Bot commented Feb 18, 2026

Copy link
Copy Markdown

Deploy Preview for scrc-coding-guidelines ready!

Name Link
🔨 Latest commit 8ec4b51
🔍 Latest deploy log https://app.netlify.com/projects/scrc-coding-guidelines/deploys/6995e38008584d0008be83ff
😎 Deploy Preview https://deploy-preview-410--scrc-coding-guidelines.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@felix91gr

Copy link
Copy Markdown
Collaborator

@PLeVasseur should it be /release @<current_reviewer_s_username> <reason>?

From the context of where the command is invoked, it would always know who the current reviewer is, right?

@sei-dsvoboda

Copy link
Copy Markdown
Collaborator

@guidelines-bot /r? producers

@github-actions

Copy link
Copy Markdown
Contributor

@cpetig is designated as reviewer by queue rotation, but GitHub could not add them to PR Reviewers automatically (API 422). A triage+ approver may still be required before merge queue.

@github-actions

Copy link
Copy Markdown
Contributor

@cpetig remains designated as reviewer in bot state. GitHub reviewer assignment could not be completed.

@github-actions github-actions Bot added the status: awaiting reviewer response Reviewer-bot is waiting on reviewer freshness or current-head review label Mar 31, 2026
@plaindocs

Copy link
Copy Markdown
Collaborator

@PLeVasseur do we need to get this merged in?

@PLeVasseur

Copy link
Copy Markdown
Collaborator Author

@PLeVasseur do we need to get this merged in?

Yeah, that'd probably be wise.

I need to reorient myself. Next week looks more open for me to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: awaiting reviewer response Reviewer-bot is waiting on reviewer freshness or current-head review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Guidelines Bot] The command /release doesn't quite work (or maybe I don't have triage+ permissions and I had no idea)

4 participants