Skip to content

Refactor reviewer-bot module imports#439

Merged
PLeVasseur merged 1 commit intoSafety-Critical-Rust-Consortium:mainfrom
PLeVasseur:refactor/reviewer-bot-direct-module-imports
Mar 17, 2026
Merged

Refactor reviewer-bot module imports#439
PLeVasseur merged 1 commit intoSafety-Critical-Rust-Consortium:mainfrom
PLeVasseur:refactor/reviewer-bot-direct-module-imports

Conversation

@PLeVasseur
Copy link
Copy Markdown
Collaborator

Summary

  • stop routing json, os, and yaml through the reviewer-bot module namespace
  • import those modules directly where they are used in extracted reviewer-bot helpers
  • keep the change narrow and validate the affected runtime paths with focused tests

What Changed

  • update lease-lock helpers to use direct json imports instead of bot.json
  • update automation helpers to use direct os imports instead of bot.os
  • update the show-state maintenance path to use a direct yaml import instead of bot.yaml
  • remove the corresponding compatibility-only imports from scripts/reviewer_bot.py
  • adjust focused reviewer-bot regression tests to reflect the reduced runtime facade

Validation

  • uv run python -m pytest .github/reviewer-bot-tests/test_main.py .github/reviewer-bot-tests/test_reviewer_bot.py
  • uv run ruff check --fix scripts .github/reviewer-bot-tests/test_main.py .github/reviewer-bot-tests/test_reviewer_bot.py

Stacking

  • first PR in the reviewer-bot facade reduction series

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 17, 2026

Deploy Preview for scrc-coding-guidelines ready!

Name Link
🔨 Latest commit f9b1efe
🔍 Latest deploy log https://app.netlify.com/projects/scrc-coding-guidelines/deploys/69b9a0dd081c9700082f821e
😎 Deploy Preview https://deploy-preview-439--scrc-coding-guidelines.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@PLeVasseur PLeVasseur merged commit 8210a6d into Safety-Critical-Rust-Consortium:main Mar 17, 2026
16 checks passed
@PLeVasseur PLeVasseur deleted the refactor/reviewer-bot-direct-module-imports branch March 17, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant