Skip to content

Refactor reviewer-bot final events cleanup#448

Merged
PLeVasseur merged 1 commit intoSafety-Critical-Rust-Consortium:mainfrom
PLeVasseur:refactor/reviewer-bot-final-events-cleanup
Mar 17, 2026
Merged

Refactor reviewer-bot final events cleanup#448
PLeVasseur merged 1 commit intoSafety-Critical-Rust-Consortium:mainfrom
PLeVasseur:refactor/reviewer-bot-final-events-cleanup

Conversation

@PLeVasseur
Copy link
Copy Markdown
Collaborator

Summary

  • extract maintenance dispatch out of events.py
  • relocate the remaining review helper functions to reviews.py
  • leave events.py as a small residual event helper module instead of a miscellaneous bucket

What Changed

  • add scripts/reviewer_bot_lib/maintenance.py and move:
    • handle_manual_dispatch
    • handle_scheduled_check
  • move the remaining review helper functions from scripts/reviewer_bot_lib/events.py into scripts/reviewer_bot_lib/reviews.py:
    • get_latest_review_by_reviewer
    • find_triage_approval_after
  • update scripts/reviewer_bot.py wrappers to route maintenance and review helpers through their new homes
  • reduce scripts/reviewer_bot_lib/events.py to a small residual module focused on runtime epoch helpers and direct PR review source-event deferral

Validation

  • uv run python -m pytest .github/reviewer-bot-tests/test_main.py .github/reviewer-bot-tests/test_reviewer_bot.py
  • uv run ruff check --fix scripts .github/reviewer-bot-tests/test_main.py .github/reviewer-bot-tests/test_reviewer_bot.py

Notes

  • this is the final cleanup slice for the events.py untangling work
  • the major spaghetti has already been split into lifecycle, comment routing, reconcile, and sweeper modules; this PR cleans up the remaining miscellaneous bucket

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 17, 2026

Deploy Preview for scrc-coding-guidelines ready!

Name Link
🔨 Latest commit dda3ba7
🔍 Latest deploy log https://app.netlify.com/projects/scrc-coding-guidelines/deploys/69b9bd03ae0a21000821db6a
😎 Deploy Preview https://deploy-preview-448--scrc-coding-guidelines.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@PLeVasseur PLeVasseur merged commit 121a0a3 into Safety-Critical-Rust-Consortium:main Mar 17, 2026
16 checks passed
@PLeVasseur PLeVasseur deleted the refactor/reviewer-bot-final-events-cleanup branch March 17, 2026 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant