Skip to content

fix(reviewer-bot): make spec-lock updates pure#511

Merged
PLeVasseur merged 1 commit intoSafety-Critical-Rust-Consortium:mainfrom
PLeVasseur:fix/reviewer-bot-privileged-spec-lock-pure-path
Mar 18, 2026
Merged

fix(reviewer-bot): make spec-lock updates pure#511
PLeVasseur merged 1 commit intoSafety-Critical-Rust-Consortium:mainfrom
PLeVasseur:fix/reviewer-bot-privileged-spec-lock-pure-path

Conversation

@PLeVasseur
Copy link
Copy Markdown
Collaborator

Summary

  • stop make.py --update-spec-lock-file from continuing into the full docs build path so /accept-no-fls-changes only performs the intended spec-lock update work
  • preserve the existing success and failure semantics by exiting with an explicit status immediately after the spec-lock update step
  • add a regression test proving update-spec-lock mode exits before build_docs(...) is invoked

Testing

  • uv run ruff check --fix builder/build_cli.py scripts/reviewer_bot_lib/automation.py .github/reviewer-bot-tests/test_reviewer_bot.py
  • uv run python -m pytest .github/reviewer-bot-tests/test_reviewer_bot.py .github/reviewer-bot-tests/test_main.py

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 18, 2026

Deploy Preview for scrc-coding-guidelines ready!

Name Link
🔨 Latest commit 554d689
🔍 Latest deploy log https://app.netlify.com/projects/scrc-coding-guidelines/deploys/69bb3b9ccccd7d0008abc2de
😎 Deploy Preview https://deploy-preview-511--scrc-coding-guidelines.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@PLeVasseur PLeVasseur merged commit 8eb6cd2 into Safety-Critical-Rust-Consortium:main Mar 18, 2026
16 checks passed
@PLeVasseur PLeVasseur deleted the fix/reviewer-bot-privileged-spec-lock-pure-path branch March 18, 2026 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant