MG-182: update agora infra based on improvements to model-ad infra #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
zaro0508
requested changes
May 19, 2025
Contributor
zaro0508
left a comment
zaro0508
left a comment
There was a problem hiding this comment.
how about include this as well? Sage-Bionetworks-IT/aws-cdk-ecs-infra-template#16 (comment)
Contributor
Author
Done! |
zaro0508
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We recently set up the Model-AD infra based on Agora's infra (Sage-Bionetworks-IT/modeladexplorer-infra#2). We identified improvements during the process that we would like to incorporate into Agora.
Changelog
environment_variablesand generalize variable name.env.exampleand describe.envin README