Refactor github action #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When triggering jobs with workflow_run the default git ref to fetch is the default branch[1], causing all deploys to use the dev branch. We want the workflow to checkout the branch that trigger the event. The github community suggested solution is to change workflow_run to workflow_call[2] [1] https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#workflow_run [2] https://github.com/orgs/community/discussions/72097#discussioncomment-7376117
tschaffter
approved these changes
Jan 15, 2025
ConsoleCatzirl
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When triggering jobs with workflow_run the default git ref to fetch is the
default branch[1], causing all deploys to use the dev branch. We want the
workflow to checkout the branch that trigger the event. The github
community suggested solution is to change workflow_run to workflow_call[2]
[1] https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#workflow_run
[2] https://github.com/orgs/community/discussions/72097#discussioncomment-7376117