Make https optional #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow users to boostrap and get started quicker by not requiring https that way users aren't required to create a certificate just to deploy this infra.
There was a problem hiding this comment.
Pull Request Overview
This PR makes HTTPS optional for the load balancer configuration, allowing users to deploy the infrastructure without requiring SSL certificates. This simplifies initial deployment and reduces the barrier to entry for getting started with the service.
Key changes:
- Added
enable_httpsparameter to control HTTPS listener creation - Made
certificate_arnoptional with a default value ofNone - Removed hardcoded certificate ARN from environment variables
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/service_stack.py | Added optional HTTPS support with new enable_https parameter and conditional listener creation logic |
| app.py | Removed hardcoded certificate ARN from environment variables and instantiation call |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
handle error when HTTPS is requested but no certificate ARN is provided. Co-authored-by: Copilot <[email protected]>
ConsoleCatzirl
approved these changes
Oct 21, 2025
zaro0508
added a commit
that referenced
this pull request
Oct 30, 2025
Use the AWS CDK built in context loader[1] and allow storing and loading configurations from files. [1] https://docs.aws.amazon.com/cdk/v2/guide/context.html depends on #25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to boostrap and get started quicker by not requiring https by default. This will allow users to deploy this infra without having to create a certificate.