VPC endpoint for guardduty #28
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CDK app now manages the GuardDuty VPC endpoint to ensure clean stack deletion. In earlier versions, GuardDuty created AWS-managed resources (VPC endpoints and security groups) outside of CloudFormation, which blocked VPC deletion. These are now explicitly managed by the CDK stack.
There was a problem hiding this comment.
Pull Request Overview
This PR adds a GuardDuty VPC endpoint to the network stack to prevent orphaned AWS-managed resources during stack deletion. When GuardDuty ECS Runtime Monitoring is enabled, AWS automatically creates VPC endpoints and security groups outside of CloudFormation, which block VPC deletion. By explicitly managing the GuardDuty VPC endpoint in the CDK stack, it can be properly destroyed with the rest of the infrastructure.
- Adds GuardDuty VPC endpoint to NetworkStack with private subnet placement
- Implements comprehensive test coverage for VPC endpoint creation, security configuration, and VPC integration
- Documents the issue and solution in README with troubleshooting guidance
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/network_stack.py | Adds GuardDuty VPC endpoint with interface type, private DNS enabled, and placement in private subnets |
| tests/unit/test_network_stack.py | Adds three test functions covering endpoint creation, security configuration, and VPC integration |
| README.md | Documents the GuardDuty VPC endpoint issue, root cause, and solution for stack deletion problems |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fix typo Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a GuardDuty VPC endpoint to the network stack to prevent orphaned AWS-managed resources during stack deletion. When GuardDuty ECS Runtime Monitoring is enabled, AWS automatically creates VPC endpoints and security groups outside of CloudFormation, which block VPC deletion. By explicitly managing the GuardDuty VPC endpoint in the CDK stack, it can be properly destroyed with the rest of the infrastructure.