Skip to content

Conversation

@zaro0508
Copy link
Contributor

@zaro0508 zaro0508 commented Sep 24, 2025

Add a script to allow admins to easily change supported service catalog provisioned product owners.

This script will do the following:

  1. Change owner at the service catalog product level
  2. Update provisioned resource tags with the new owner info
  3. Update bucket policies to allow the new owner read/write access to the bucket

Limitations:

  1. New users are able to stop, start, and restart the instance from the service catalog actions. However they will not be able to access an EC2 terminal session or notebook or webui session.

Note: this script only works when executed with Admin access

depends on #63

Add a script to allow admins to easily change supported service
catalog provisioned product owners.

This script will do the following:
1. Change owner at the service catalog product level
2. Update resource tags with the new owner info
3. Update bucket policies to allow the new owner access to data

Limitations:
1. This script will not chnage EC2 or notebook access to allow new
user console or webui access to an EC2 or notebook applications
@zaro0508 zaro0508 requested review from a team as code owners September 24, 2025 00:45
@zaro0508 zaro0508 marked this pull request as draft September 24, 2025 00:45
@zaro0508 zaro0508 requested a review from Copilot September 24, 2025 18:21
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new administrative script to change ownership of Service Catalog provisioned products. The script handles ownership changes at multiple levels including Service Catalog product ownership, resource tags, and S3 bucket policies.

  • Adds a comprehensive change_owner.py script that supports changing ownership for buckets, EC2 instances, and batch scheduled jobs
  • Updates the Pipfile to include a convenient script entry point for the new functionality
  • Implements utility functions for ARN parsing, bucket policy updates, and CloudFormation resource retrieval

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
change_owner.py Main script implementing ownership change functionality with support for S3 buckets, EC2 instances, and batch jobs
Pipfile Adds script entry point for the change_owner command
Comments suppressed due to low confidence (1)

change_owner.py:1

  • Typo in the description comment: 'chnage' should be 'change'.
# A wrapper script to Change ownership of Service Catalog provisioned products.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@zaro0508 zaro0508 marked this pull request as ready for review September 24, 2025 18:33
@zaro0508 zaro0508 requested a review from a team September 24, 2025 20:31
@dpulls
Copy link

dpulls bot commented Sep 25, 2025

🎉 All dependencies have been resolved !

@zaro0508 zaro0508 merged commit bebc838 into Sage-Bionetworks-IT:master Sep 26, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants