-
Notifications
You must be signed in to change notification settings - Fork 4
[IT-4483] Change service catalog product owner #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add a script to allow admins to easily change supported service catalog provisioned product owners. This script will do the following: 1. Change owner at the service catalog product level 2. Update resource tags with the new owner info 3. Update bucket policies to allow the new owner access to data Limitations: 1. This script will not chnage EC2 or notebook access to allow new user console or webui access to an EC2 or notebook applications
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new administrative script to change ownership of Service Catalog provisioned products. The script handles ownership changes at multiple levels including Service Catalog product ownership, resource tags, and S3 bucket policies.
- Adds a comprehensive
change_owner.pyscript that supports changing ownership for buckets, EC2 instances, and batch scheduled jobs - Updates the Pipfile to include a convenient script entry point for the new functionality
- Implements utility functions for ARN parsing, bucket policy updates, and CloudFormation resource retrieval
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| change_owner.py | Main script implementing ownership change functionality with support for S3 buckets, EC2 instances, and batch jobs |
| Pipfile | Adds script entry point for the change_owner command |
Comments suppressed due to low confidence (1)
change_owner.py:1
- Typo in the description comment: 'chnage' should be 'change'.
# A wrapper script to Change ownership of Service Catalog provisioned products.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
🎉 All dependencies have been resolved ! |
Add a script to allow admins to easily change supported service catalog provisioned product owners.
This script will do the following:
Limitations:
Note: this script only works when executed with Admin access
depends on #63