Skip to content

[IT-3951] Fix guardduty container #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zaro0508 merged 3 commits into from
Dec 3, 2024
Merged

[IT-3951] Fix guardduty container #71

zaro0508 merged 3 commits into from
Dec 3, 2024

Conversation

@zaro0508
Copy link
Contributor

@zaro0508 zaro0508 commented Dec 3, 2024 •
edited
Loading

We enable guardduty security monitoring for ECS in every account.
For that to work we need to give Fragate tasks access to do ECS stuff
with the service-role/AmazonECSTaskExecutionRolePolicy[1].

[1] https://docs.aws.amazon.com/guardduty/latest/ug/prereq-runtime-monitoring-ecs-support.html#before-enable-runtime-monitoring-ecs

@zaro0508
[IT-3951] Fix guardduty container
b7ca886 
We enable guardduty security monitoring for ECS in every account.
For that to work we need to give Fragate tasks access to do ECS
stuff with the service-role/AmazonECSTaskExecutionRolePolicy[1].

[1] https://docs.aws.amazon.com/guardduty/latest/ug/prereq-runtime-monitoring-ecs-support.html#before-enable-runtime-monitoring-ecs
@zaro0508 zaro0508 requested review from a team as code owners December 3, 2024 00:47
brucehoff
brucehoff approved these changes Dec 3, 2024 •
edited
Loading
View reviewed changes
@brucehoff brucehoff self-requested a review December 3, 2024 00:54
brucehoff
brucehoff requested changes Dec 3, 2024
View reviewed changes
Copy link

@brucehoff brucehoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not the 'task_role' but the 'execution_role' that requires permission to access ECR and ECS.

@brucehoff
Copy link

brucehoff commented Dec 3, 2024

@zaro0508 Please see the doc's. The 'task_role' gives the container permission while the 'execution_role' gives the ECS agent permission. It's the ECS agent, not the task(s) that will launch the GuardDuty container. So it's the 'execution_role' that needs to be given greater permissions.

@zaro0508
Copy link
Contributor Author

zaro0508 commented Dec 3, 2024

ok, it's fixed @brucehoff

@zaro0508 zaro0508 requested review from a team and brucehoff December 3, 2024 20:33
@zaro0508 zaro0508 merged commit 9965cd4 into Sage-Bionetworks-IT:dev Dec 3, 2024
3 checks passed
tschaffter added a commit that referenced this pull request Dec 10, 2024
@tschaffter @pre-commit-ci
@zaro0508 @ConsoleCatzirl
Merge dev to stage (#76)
be639e2 
* [pre-commit.ci] pre-commit autoupdate (#48)

updates:
- [github.com/PyCQA/flake8: 7.1.0 → 7.1.1](PyCQA/flake8@7.1.0...7.1.1)
- [github.com/awslabs/cfn-python-lint: v1.9.0 → v1.15.0](aws-cloudformation/cfn-lint@v1.9.0...v1.15.0)
- [github.com/psf/black: 24.4.2 → 24.8.0](psf/black@24.4.2...24.8.0)
- [github.com/sirosen/check-jsonschema: 0.29.1 → 0.29.2](python-jsonschema/check-jsonschema@0.29.1...0.29.2)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* [IT-3918] Fix the image URLs returned by the image service (#51)

* update the config of the image service

* use `{fully_qualified_domain_name}`

* use an f-string

* [pre-commit.ci] pre-commit autoupdate (#52)

updates:
- [github.com/awslabs/cfn-python-lint: v1.15.0 → v1.15.2](aws-cloudformation/cfn-lint@v1.15.0...v1.15.2)
- [github.com/sirosen/check-jsonschema: 0.29.2 → 0.29.3](python-jsonschema/check-jsonschema@0.29.2...0.29.3)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* [pre-commit.ci] pre-commit autoupdate (#53)

updates:
- [github.com/pre-commit/pre-commit-hooks: v4.6.0 → v5.0.0](pre-commit/pre-commit-hooks@v4.6.0...v5.0.0)
- [github.com/awslabs/cfn-python-lint: v1.15.2 → v1.16.0](aws-cloudformation/cfn-lint@v1.15.2...v1.16.0)
- [github.com/psf/black: 24.8.0 → 24.10.0](psf/black@24.8.0...24.10.0)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Parametrize stack version and update app config (#54)

* parametrize stack version

* update data update date

* set Google tag manager ID

* rename `stack_version` to `image_version`

* Increase GH workflow timeout (#55)

A change[1] was made to update all containers at the same time
which takes longer to deploy so we need to increase the deployment
timeout.

[1] #54

* [pre-commit.ci] pre-commit autoupdate (#56)

updates:
- [github.com/awslabs/cfn-python-lint: v1.16.0 → v1.16.1](aws-cloudformation/cfn-lint@v1.16.0...v1.16.1)
- [github.com/sirosen/check-jsonschema: 0.29.3 → 0.29.4](python-jsonschema/check-jsonschema@0.29.3...0.29.4)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* [pre-commit.ci] pre-commit autoupdate (#59)

updates:
- [github.com/awslabs/cfn-python-lint: v1.16.1 → v1.18.1](aws-cloudformation/cfn-lint@v1.16.1...v1.18.1)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* [pre-commit.ci] pre-commit autoupdate (#60)

updates:
- [github.com/awslabs/cfn-python-lint: v1.18.1 → v1.18.2](aws-cloudformation/cfn-lint@v1.18.1...v1.18.2)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Set concurrency to 5 (best results) (#61)

* [pre-commit.ci] pre-commit autoupdate (#62)

updates:
- [github.com/awslabs/cfn-python-lint: v1.18.2 → v1.18.4](aws-cloudformation/cfn-lint@v1.18.2...v1.18.4)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* update image tag, app version and data release date (#63)

* [pre-commit.ci] pre-commit autoupdate (#66)

updates:
- [github.com/awslabs/cfn-python-lint: v1.18.4 → v1.19.0](aws-cloudformation/cfn-lint@v1.18.4...v1.19.0)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Refactor mounting volumes (#67)

The current implementation to mount volumes was very specific to one
container.  We are replacing it with an implementation that is much
more generic to make it easy to mount volumes in other containers.

* [IT-4003] Auto-update pre-commit hook versions monthly

Change the frequency that PRs to update pre-commit hook versions are
auto-generated from weekly (the default) to monthly.

* Update to OC v1.1.1 (#69)

* Update to v1.1.1

* update data updated on

* [pre-commit.ci] pre-commit autoupdate (#70)

updates:
- [github.com/awslabs/cfn-python-lint: v1.19.0 → v1.20.1](aws-cloudformation/cfn-lint@v1.19.0...v1.20.1)
- [github.com/sirosen/check-jsonschema: 0.29.4 → 0.30.0](python-jsonschema/check-jsonschema@0.29.4...0.30.0)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* [IT-3951] Fix guardduty container (#71)

We enable guardduty security monitoring for ECS in every account.
For that to work we need to give Fragate tasks access to do ECS stuff
with the service-role/AmazonECSTaskExecutionRolePolicy[1].

[1] https://docs.aws.amazon.com/guardduty/latest/ug/prereq-runtime-monitoring-ecs-support.html#before-enable-runtime-monitoring-ecs

* remove source.bat (#74)

* Add Docker in Docker to the dev container (#73)

* Add Docker in Docker to the devcontainer

* add docs about docker

* forward local environment variables to the devcontainer

* remove containerEnv

* Add AWS Lambda for upcoming data integration (ARCH-356) (#72)

* update docs on setup tools

* define lambda role and function

* update path to Dockerfile

* update README

* trigger the lambda every 5 minutes

* use plural form of the unit

* Remove lambda fct architecture

* Migrate data integration code to L2 constructs

* Add @DataClass to DataIntegrationProps

* Add docstrings

* Replace `_lambda` by `lambda_`

* Add docstrings

* Add docstrings

* Externalize the description of the schedule (#75)

* define lambda role and function

* update path to Dockerfile

* Externalize the description of the schedule

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Khai Do <3697686+zaro0508@users.noreply.github.com>
Co-authored-by: Joni Harker <joni.harker@sagebase.org>
Co-authored-by: Joni Harker <506966+ConsoleCatzirl@users.noreply.github.com>
tschaffter added a commit that referenced this pull request Dec 11, 2024
@tschaffter @pre-commit-ci
@zaro0508 @ConsoleCatzirl
Merge stage into prod (#77)
d084526 
* Update stage environment (#57)

* [pre-commit.ci] pre-commit autoupdate (#48)

updates:
- [github.com/PyCQA/flake8: 7.1.0 → 7.1.1](PyCQA/flake8@7.1.0...7.1.1)
- [github.com/awslabs/cfn-python-lint: v1.9.0 → v1.15.0](aws-cloudformation/cfn-lint@v1.9.0...v1.15.0)
- [github.com/psf/black: 24.4.2 → 24.8.0](psf/black@24.4.2...24.8.0)
- [github.com/sirosen/check-jsonschema: 0.29.1 → 0.29.2](python-jsonschema/check-jsonschema@0.29.1...0.29.2)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* [IT-3918] Fix the image URLs returned by the image service (#51)

* update the config of the image service

* use `{fully_qualified_domain_name}`

* use an f-string

* [pre-commit.ci] pre-commit autoupdate (#52)

updates:
- [github.com/awslabs/cfn-python-lint: v1.15.0 → v1.15.2](aws-cloudformation/cfn-lint@v1.15.0...v1.15.2)
- [github.com/sirosen/check-jsonschema: 0.29.2 → 0.29.3](python-jsonschema/check-jsonschema@0.29.2...0.29.3)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* [pre-commit.ci] pre-commit autoupdate (#53)

updates:
- [github.com/pre-commit/pre-commit-hooks: v4.6.0 → v5.0.0](pre-commit/pre-commit-hooks@v4.6.0...v5.0.0)
- [github.com/awslabs/cfn-python-lint: v1.15.2 → v1.16.0](aws-cloudformation/cfn-lint@v1.15.2...v1.16.0)
- [github.com/psf/black: 24.8.0 → 24.10.0](psf/black@24.8.0...24.10.0)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Parametrize stack version and update app config (#54)

* parametrize stack version

* update data update date

* set Google tag manager ID

* rename `stack_version` to `image_version`

* Increase GH workflow timeout (#55)

A change[1] was made to update all containers at the same time
which takes longer to deploy so we need to increase the deployment
timeout.

[1] #54

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Khai Do <3697686+zaro0508@users.noreply.github.com>

* Merge dev to stage (#76)

* [pre-commit.ci] pre-commit autoupdate (#48)

updates:
- [github.com/PyCQA/flake8: 7.1.0 → 7.1.1](PyCQA/flake8@7.1.0...7.1.1)
- [github.com/awslabs/cfn-python-lint: v1.9.0 → v1.15.0](aws-cloudformation/cfn-lint@v1.9.0...v1.15.0)
- [github.com/psf/black: 24.4.2 → 24.8.0](psf/black@24.4.2...24.8.0)
- [github.com/sirosen/check-jsonschema: 0.29.1 → 0.29.2](python-jsonschema/check-jsonschema@0.29.1...0.29.2)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* [IT-3918] Fix the image URLs returned by the image service (#51)

* update the config of the image service

* use `{fully_qualified_domain_name}`

* use an f-string

* [pre-commit.ci] pre-commit autoupdate (#52)

updates:
- [github.com/awslabs/cfn-python-lint: v1.15.0 → v1.15.2](aws-cloudformation/cfn-lint@v1.15.0...v1.15.2)
- [github.com/sirosen/check-jsonschema: 0.29.2 → 0.29.3](python-jsonschema/check-jsonschema@0.29.2...0.29.3)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* [pre-commit.ci] pre-commit autoupdate (#53)

updates:
- [github.com/pre-commit/pre-commit-hooks: v4.6.0 → v5.0.0](pre-commit/pre-commit-hooks@v4.6.0...v5.0.0)
- [github.com/awslabs/cfn-python-lint: v1.15.2 → v1.16.0](aws-cloudformation/cfn-lint@v1.15.2...v1.16.0)
- [github.com/psf/black: 24.8.0 → 24.10.0](psf/black@24.8.0...24.10.0)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Parametrize stack version and update app config (#54)

* parametrize stack version

* update data update date

* set Google tag manager ID

* rename `stack_version` to `image_version`

* Increase GH workflow timeout (#55)

A change[1] was made to update all containers at the same time
which takes longer to deploy so we need to increase the deployment
timeout.

[1] #54

* [pre-commit.ci] pre-commit autoupdate (#56)

updates:
- [github.com/awslabs/cfn-python-lint: v1.16.0 → v1.16.1](aws-cloudformation/cfn-lint@v1.16.0...v1.16.1)
- [github.com/sirosen/check-jsonschema: 0.29.3 → 0.29.4](python-jsonschema/check-jsonschema@0.29.3...0.29.4)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* [pre-commit.ci] pre-commit autoupdate (#59)

updates:
- [github.com/awslabs/cfn-python-lint: v1.16.1 → v1.18.1](aws-cloudformation/cfn-lint@v1.16.1...v1.18.1)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* [pre-commit.ci] pre-commit autoupdate (#60)

updates:
- [github.com/awslabs/cfn-python-lint: v1.18.1 → v1.18.2](aws-cloudformation/cfn-lint@v1.18.1...v1.18.2)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Set concurrency to 5 (best results) (#61)

* [pre-commit.ci] pre-commit autoupdate (#62)

updates:
- [github.com/awslabs/cfn-python-lint: v1.18.2 → v1.18.4](aws-cloudformation/cfn-lint@v1.18.2...v1.18.4)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* update image tag, app version and data release date (#63)

* [pre-commit.ci] pre-commit autoupdate (#66)

updates:
- [github.com/awslabs/cfn-python-lint: v1.18.4 → v1.19.0](aws-cloudformation/cfn-lint@v1.18.4...v1.19.0)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Refactor mounting volumes (#67)

The current implementation to mount volumes was very specific to one
container.  We are replacing it with an implementation that is much
more generic to make it easy to mount volumes in other containers.

* [IT-4003] Auto-update pre-commit hook versions monthly

Change the frequency that PRs to update pre-commit hook versions are
auto-generated from weekly (the default) to monthly.

* Update to OC v1.1.1 (#69)

* Update to v1.1.1

* update data updated on

* [pre-commit.ci] pre-commit autoupdate (#70)

updates:
- [github.com/awslabs/cfn-python-lint: v1.19.0 → v1.20.1](aws-cloudformation/cfn-lint@v1.19.0...v1.20.1)
- [github.com/sirosen/check-jsonschema: 0.29.4 → 0.30.0](python-jsonschema/check-jsonschema@0.29.4...0.30.0)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* [IT-3951] Fix guardduty container (#71)

We enable guardduty security monitoring for ECS in every account.
For that to work we need to give Fragate tasks access to do ECS stuff
with the service-role/AmazonECSTaskExecutionRolePolicy[1].

[1] https://docs.aws.amazon.com/guardduty/latest/ug/prereq-runtime-monitoring-ecs-support.html#before-enable-runtime-monitoring-ecs

* remove source.bat (#74)

* Add Docker in Docker to the dev container (#73)

* Add Docker in Docker to the devcontainer

* add docs about docker

* forward local environment variables to the devcontainer

* remove containerEnv

* Add AWS Lambda for upcoming data integration (ARCH-356) (#72)

* update docs on setup tools

* define lambda role and function

* update path to Dockerfile

* update README

* trigger the lambda every 5 minutes

* use plural form of the unit

* Remove lambda fct architecture

* Migrate data integration code to L2 constructs

* Add @DataClass to DataIntegrationProps

* Add docstrings

* Replace `_lambda` by `lambda_`

* Add docstrings

* Add docstrings

* Externalize the description of the schedule (#75)

* define lambda role and function

* update path to Dockerfile

* Externalize the description of the schedule

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Khai Do <3697686+zaro0508@users.noreply.github.com>
Co-authored-by: Joni Harker <joni.harker@sagebase.org>
Co-authored-by: Joni Harker <506966+ConsoleCatzirl@users.noreply.github.com>

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Khai Do <3697686+zaro0508@users.noreply.github.com>
Co-authored-by: Joni Harker <joni.harker@sagebase.org>
Co-authored-by: Joni Harker <506966+ConsoleCatzirl@users.noreply.github.com>
tschaffter added a commit that referenced this pull request Dec 13, 2024
@tschaffter @pre-commit-ci
@zaro0508 @ConsoleCatzirl
Deploy OC v1.1.2 to prod (#81)
7e18c4b 
* [pre-commit.ci] pre-commit autoupdate (#48)

updates:
- [github.com/PyCQA/flake8: 7.1.0 → 7.1.1](PyCQA/flake8@7.1.0...7.1.1)
- [github.com/awslabs/cfn-python-lint: v1.9.0 → v1.15.0](aws-cloudformation/cfn-lint@v1.9.0...v1.15.0)
- [github.com/psf/black: 24.4.2 → 24.8.0](psf/black@24.4.2...24.8.0)
- [github.com/sirosen/check-jsonschema: 0.29.1 → 0.29.2](python-jsonschema/check-jsonschema@0.29.1...0.29.2)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* [IT-3918] Fix the image URLs returned by the image service (#51)

* update the config of the image service

* use `{fully_qualified_domain_name}`

* use an f-string

* [pre-commit.ci] pre-commit autoupdate (#52)

updates:
- [github.com/awslabs/cfn-python-lint: v1.15.0 → v1.15.2](aws-cloudformation/cfn-lint@v1.15.0...v1.15.2)
- [github.com/sirosen/check-jsonschema: 0.29.2 → 0.29.3](python-jsonschema/check-jsonschema@0.29.2...0.29.3)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* [pre-commit.ci] pre-commit autoupdate (#53)

updates:
- [github.com/pre-commit/pre-commit-hooks: v4.6.0 → v5.0.0](pre-commit/pre-commit-hooks@v4.6.0...v5.0.0)
- [github.com/awslabs/cfn-python-lint: v1.15.2 → v1.16.0](aws-cloudformation/cfn-lint@v1.15.2...v1.16.0)
- [github.com/psf/black: 24.8.0 → 24.10.0](psf/black@24.8.0...24.10.0)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Parametrize stack version and update app config (#54)

* parametrize stack version

* update data update date

* set Google tag manager ID

* rename `stack_version` to `image_version`

* Increase GH workflow timeout (#55)

A change[1] was made to update all containers at the same time
which takes longer to deploy so we need to increase the deployment
timeout.

[1] #54

* Update stage environment (#57)

* [pre-commit.ci] pre-commit autoupdate (#48)

updates:
- [github.com/PyCQA/flake8: 7.1.0 → 7.1.1](PyCQA/flake8@7.1.0...7.1.1)
- [github.com/awslabs/cfn-python-lint: v1.9.0 → v1.15.0](aws-cloudformation/cfn-lint@v1.9.0...v1.15.0)
- [github.com/psf/black: 24.4.2 → 24.8.0](psf/black@24.4.2...24.8.0)
- [github.com/sirosen/check-jsonschema: 0.29.1 → 0.29.2](python-jsonschema/check-jsonschema@0.29.1...0.29.2)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* [IT-3918] Fix the image URLs returned by the image service (#51)

* update the config of the image service

* use `{fully_qualified_domain_name}`

* use an f-string

* [pre-commit.ci] pre-commit autoupdate (#52)

updates:
- [github.com/awslabs/cfn-python-lint: v1.15.0 → v1.15.2](aws-cloudformation/cfn-lint@v1.15.0...v1.15.2)
- [github.com/sirosen/check-jsonschema: 0.29.2 → 0.29.3](python-jsonschema/check-jsonschema@0.29.2...0.29.3)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* [pre-commit.ci] pre-commit autoupdate (#53)

updates:
- [github.com/pre-commit/pre-commit-hooks: v4.6.0 → v5.0.0](pre-commit/pre-commit-hooks@v4.6.0...v5.0.0)
- [github.com/awslabs/cfn-python-lint: v1.15.2 → v1.16.0](aws-cloudformation/cfn-lint@v1.15.2...v1.16.0)
- [github.com/psf/black: 24.8.0 → 24.10.0](psf/black@24.8.0...24.10.0)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Parametrize stack version and update app config (#54)

* parametrize stack version

* update data update date

* set Google tag manager ID

* rename `stack_version` to `image_version`

* Increase GH workflow timeout (#55)

A change[1] was made to update all containers at the same time
which takes longer to deploy so we need to increase the deployment
timeout.

[1] #54

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Khai Do <3697686+zaro0508@users.noreply.github.com>

* [pre-commit.ci] pre-commit autoupdate (#56)

updates:
- [github.com/awslabs/cfn-python-lint: v1.16.0 → v1.16.1](aws-cloudformation/cfn-lint@v1.16.0...v1.16.1)
- [github.com/sirosen/check-jsonschema: 0.29.3 → 0.29.4](python-jsonschema/check-jsonschema@0.29.3...0.29.4)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* [pre-commit.ci] pre-commit autoupdate (#59)

updates:
- [github.com/awslabs/cfn-python-lint: v1.16.1 → v1.18.1](aws-cloudformation/cfn-lint@v1.16.1...v1.18.1)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* [pre-commit.ci] pre-commit autoupdate (#60)

updates:
- [github.com/awslabs/cfn-python-lint: v1.18.1 → v1.18.2](aws-cloudformation/cfn-lint@v1.18.1...v1.18.2)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Set concurrency to 5 (best results) (#61)

* [pre-commit.ci] pre-commit autoupdate (#62)

updates:
- [github.com/awslabs/cfn-python-lint: v1.18.2 → v1.18.4](aws-cloudformation/cfn-lint@v1.18.2...v1.18.4)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* update image tag, app version and data release date (#63)

* [pre-commit.ci] pre-commit autoupdate (#66)

updates:
- [github.com/awslabs/cfn-python-lint: v1.18.4 → v1.19.0](aws-cloudformation/cfn-lint@v1.18.4...v1.19.0)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Refactor mounting volumes (#67)

The current implementation to mount volumes was very specific to one
container.  We are replacing it with an implementation that is much
more generic to make it easy to mount volumes in other containers.

* [IT-4003] Auto-update pre-commit hook versions monthly

Change the frequency that PRs to update pre-commit hook versions are
auto-generated from weekly (the default) to monthly.

* Update to OC v1.1.1 (#69)

* Update to v1.1.1

* update data updated on

* [pre-commit.ci] pre-commit autoupdate (#70)

updates:
- [github.com/awslabs/cfn-python-lint: v1.19.0 → v1.20.1](aws-cloudformation/cfn-lint@v1.19.0...v1.20.1)
- [github.com/sirosen/check-jsonschema: 0.29.4 → 0.30.0](python-jsonschema/check-jsonschema@0.29.4...0.30.0)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* [IT-3951] Fix guardduty container (#71)

We enable guardduty security monitoring for ECS in every account.
For that to work we need to give Fragate tasks access to do ECS stuff
with the service-role/AmazonECSTaskExecutionRolePolicy[1].

[1] https://docs.aws.amazon.com/guardduty/latest/ug/prereq-runtime-monitoring-ecs-support.html#before-enable-runtime-monitoring-ecs

* remove source.bat (#74)

* Add Docker in Docker to the dev container (#73)

* Add Docker in Docker to the devcontainer

* add docs about docker

* forward local environment variables to the devcontainer

* remove containerEnv

* Add AWS Lambda for upcoming data integration (ARCH-356) (#72)

* update docs on setup tools

* define lambda role and function

* update path to Dockerfile

* update README

* trigger the lambda every 5 minutes

* use plural form of the unit

* Remove lambda fct architecture

* Migrate data integration code to L2 constructs

* Add @DataClass to DataIntegrationProps

* Add docstrings

* Replace `_lambda` by `lambda_`

* Add docstrings

* Add docstrings

* Externalize the description of the schedule (#75)

* define lambda role and function

* update path to Dockerfile

* Externalize the description of the schedule

* Merge dev to stage (#76)

* [pre-commit.ci] pre-commit autoupdate (#48)

updates:
- [github.com/PyCQA/flake8: 7.1.0 → 7.1.1](PyCQA/flake8@7.1.0...7.1.1)
- [github.com/awslabs/cfn-python-lint: v1.9.0 → v1.15.0](aws-cloudformation/cfn-lint@v1.9.0...v1.15.0)
- [github.com/psf/black: 24.4.2 → 24.8.0](psf/black@24.4.2...24.8.0)
- [github.com/sirosen/check-jsonschema: 0.29.1 → 0.29.2](python-jsonschema/check-jsonschema@0.29.1...0.29.2)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* [IT-3918] Fix the image URLs returned by the image service (#51)

* update the config of the image service

* use `{fully_qualified_domain_name}`

* use an f-string

* [pre-commit.ci] pre-commit autoupdate (#52)

updates:
- [github.com/awslabs/cfn-python-lint: v1.15.0 → v1.15.2](aws-cloudformation/cfn-lint@v1.15.0...v1.15.2)
- [github.com/sirosen/check-jsonschema: 0.29.2 → 0.29.3](python-jsonschema/check-jsonschema@0.29.2...0.29.3)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* [pre-commit.ci] pre-commit autoupdate (#53)

updates:
- [github.com/pre-commit/pre-commit-hooks: v4.6.0 → v5.0.0](pre-commit/pre-commit-hooks@v4.6.0...v5.0.0)
- [github.com/awslabs/cfn-python-lint: v1.15.2 → v1.16.0](aws-cloudformation/cfn-lint@v1.15.2...v1.16.0)
- [github.com/psf/black: 24.8.0 → 24.10.0](psf/black@24.8.0...24.10.0)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Parametrize stack version and update app config (#54)

* parametrize stack version

* update data update date

* set Google tag manager ID

* rename `stack_version` to `image_version`

* Increase GH workflow timeout (#55)

A change[1] was made to update all containers at the same time
which takes longer to deploy so we need to increase the deployment
timeout.

[1] #54

* [pre-commit.ci] pre-commit autoupdate (#56)

updates:
- [github.com/awslabs/cfn-python-lint: v1.16.0 → v1.16.1](aws-cloudformation/cfn-lint@v1.16.0...v1.16.1)
- [github.com/sirosen/check-jsonschema: 0.29.3 → 0.29.4](python-jsonschema/check-jsonschema@0.29.3...0.29.4)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* [pre-commit.ci] pre-commit autoupdate (#59)

updates:
- [github.com/awslabs/cfn-python-lint: v1.16.1 → v1.18.1](aws-cloudformation/cfn-lint@v1.16.1...v1.18.1)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* [pre-commit.ci] pre-commit autoupdate (#60)

updates:
- [github.com/awslabs/cfn-python-lint: v1.18.1 → v1.18.2](aws-cloudformation/cfn-lint@v1.18.1...v1.18.2)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Set concurrency to 5 (best results) (#61)

* [pre-commit.ci] pre-commit autoupdate (#62)

updates:
- [github.com/awslabs/cfn-python-lint: v1.18.2 → v1.18.4](aws-cloudformation/cfn-lint@v1.18.2...v1.18.4)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* update image tag, app version and data release date (#63)

* [pre-commit.ci] pre-commit autoupdate (#66)

updates:
- [github.com/awslabs/cfn-python-lint: v1.18.4 → v1.19.0](aws-cloudformation/cfn-lint@v1.18.4...v1.19.0)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Refactor mounting volumes (#67)

The current implementation to mount volumes was very specific to one
container.  We are replacing it with an implementation that is much
more generic to make it easy to mount volumes in other containers.

* [IT-4003] Auto-update pre-commit hook versions monthly

Change the frequency that PRs to update pre-commit hook versions are
auto-generated from weekly (the default) to monthly.

* Update to OC v1.1.1 (#69)

* Update to v1.1.1

* update data updated on

* [pre-commit.ci] pre-commit autoupdate (#70)

updates:
- [github.com/awslabs/cfn-python-lint: v1.19.0 → v1.20.1](aws-cloudformation/cfn-lint@v1.19.0...v1.20.1)
- [github.com/sirosen/check-jsonschema: 0.29.4 → 0.30.0](python-jsonschema/check-jsonschema@0.29.4...0.30.0)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* [IT-3951] Fix guardduty container (#71)

We enable guardduty security monitoring for ECS in every account.
For that to work we need to give Fragate tasks access to do ECS stuff
with the service-role/AmazonECSTaskExecutionRolePolicy[1].

[1] https://docs.aws.amazon.com/guardduty/latest/ug/prereq-runtime-monitoring-ecs-support.html#before-enable-runtime-monitoring-ecs

* remove source.bat (#74)

* Add Docker in Docker to the dev container (#73)

* Add Docker in Docker to the devcontainer

* add docs about docker

* forward local environment variables to the devcontainer

* remove containerEnv

* Add AWS Lambda for upcoming data integration (ARCH-356) (#72)

* update docs on setup tools

* define lambda role and function

* update path to Dockerfile

* update README

* trigger the lambda every 5 minutes

* use plural form of the unit

* Remove lambda fct architecture

* Migrate data integration code to L2 constructs

* Add @DataClass to DataIntegrationProps

* Add docstrings

* Replace `_lambda` by `lambda_`

* Add docstrings

* Add docstrings

* Externalize the description of the schedule (#75)

* define lambda role and function

* update path to Dockerfile

* Externalize the description of the schedule

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Khai Do <3697686+zaro0508@users.noreply.github.com>
Co-authored-by: Joni Harker <joni.harker@sagebase.org>
Co-authored-by: Joni Harker <506966+ConsoleCatzirl@users.noreply.github.com>

* update dev (#78)

* Increase role duration to 90 minutes (#79)

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Khai Do <3697686+zaro0508@users.noreply.github.com>
Co-authored-by: Joni Harker <joni.harker@sagebase.org>
Co-authored-by: Joni Harker <506966+ConsoleCatzirl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brucehoff brucehoff brucehoff approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zaro0508 @brucehoff