Plfm 9092 #1467
Plfm 9092 #1467
Conversation
…to acess Synapse dev' account
|
|
1 similar comment
|
|
| - owner: "Sage-Bionetworks" | ||
| name: "Synapse-Repository-Services" | ||
| branches: ["*"] | ||
| - owner: "brucehoff" |
There was a problem hiding this comment.
Do developers need to deploy from their forks? Could each developer have a branch on the origin repo instead?
Also, I don't know much about the platform build process, but if these are all deploying to the same EC2 then I worry about developers breaking the build with parallel deploys, or one failed build blocking all other developers.
There was a problem hiding this comment.
@ConsoleCatzirl Great questions. The goal is NOT to deploy infrastructure (though there are AWS elements deployed along the way) but rather to run a build in AWS CodePipeline. I.e. the GitHub workflow-based builds, run in developer's forks prior to opening a PR, will be run in CodePipeline instead of on the old Jenkins server. With that understanding here are the answers to your questions:
Do developers need to deploy from their forks?
Developers will we running builds on their forks prior to creating pull requests. To do this, the GitHub workflow needs to create a CodePipeline and also to run a private copy of the Synapse back end, using the Synapse Stack Builder. So developers will be "deploying from their forks" only those AWS elements needed to run their builds.
Could each developer have a branch on the origin repo instead?
The use is for running builds prior to creating a PR or merging into the origin (upstream ) repo'.
if these are all deploying to the same EC2...
Each of the parallel builds will use private/dedicated AWS elements (a dedicated CodePipeline and a dedicated copy of the Synapse back end). Using dedicated copies of the Synapse back end is the team's approach to running builds today.
There was a problem hiding this comment.
Ah, thanks, this makes a lot more sense knowing that it's running a build in CodePipeline.
| - owner: "Sage-Bionetworks" | ||
| name: "Synapse-Repository-Services" | ||
| branches: ["*"] | ||
| - owner: "brucehoff" |
There was a problem hiding this comment.
Ah, thanks, this makes a lot more sense knowing that it's running a build in CodePipeline.
2 participants
OIDC integration allowing developer forks of Synapse repo to access Synapse dev' account
depends on Sage-Bionetworks/aws-infra#437 and assumes a tag on that repo' of v0.10.4